From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Carlos Maiolino <cem@kernel.org>, xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH 1/2] libfrog: move crc32c selftest buffer into a separate file
Date: Sat, 18 Mar 2023 11:47:05 +1100 [thread overview]
Message-ID: <ZBUKCRR7xvIqPrpX@destitution> (raw)
In-Reply-To: <20230316165101.GN11376@frogsfrogsfrogs>
On Thu, Mar 16, 2023 at 09:51:01AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Move the random buffer used for selftests into a separate file so that
> we can link to it from multiple places.
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
> libfrog/Makefile | 6 -
> libfrog/crc32cselftest.h | 526 +---------------------------------------------
> libfrog/randbytes.c | 527 ++++++++++++++++++++++++++++++++++++++++++++++
> libfrog/randbytes.h | 11 +
> 4 files changed, 548 insertions(+), 522 deletions(-)
> create mode 100644 libfrog/randbytes.c
> create mode 100644 libfrog/randbytes.h
looks fine.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2023-03-18 0:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 16:51 [PATCH 1/2] libfrog: move crc32c selftest buffer into a separate file Darrick J. Wong
2023-03-16 16:52 ` [PATCH 2/2] misc: test the dir/attr hash before formatting or repairing fs Darrick J. Wong
2023-03-18 0:47 ` Dave Chinner
2023-03-18 0:47 ` Dave Chinner [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-04-06 0:07 [PATCHSET 0/2] xfsprogs: test the dir/attr hash function Darrick J. Wong
2023-04-06 0:07 ` [PATCH 1/2] libfrog: move crc32c selftest buffer into a separate file Darrick J. Wong
2023-04-11 4:59 ` Christoph Hellwig
2023-04-21 8:58 ` Carlos Maiolino
2023-04-21 15:38 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBUKCRR7xvIqPrpX@destitution \
--to=david@fromorbit.com \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox