From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Ye Bin <yebin@huaweicloud.com>,
linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Ye Bin <yebin10@huawei.com>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] xfs: fix BUG_ON in xfs_getbmap()
Date: Mon, 27 Mar 2023 18:49:22 -0700 [thread overview]
Message-ID: <ZCJHotVOmvK+/P/k@infradead.org> (raw)
In-Reply-To: <20230327151524.GC16180@frogsfrogsfrogs>
On Mon, Mar 27, 2023 at 08:15:24AM -0700, Darrick J. Wong wrote:
> > There's issue as follows:
> > XFS: Assertion failed: (bmv->bmv_iflags & BMV_IF_DELALLOC) != 0, file: fs/xfs/xfs_bmap_util.c, line: 329
>
> Why not get rid of the assertion? It's not like it changes the course
> of the code flow -- userspace still gets told there's a delalloc extent.
>
> Or, if the assert does serve some purpose, then do we need to take
> the mmaplock for cow fork reporting too?
Looking at the COW fork reporting I think it's actually even more
broken as it never tried to flush data to start with. But COW
report is a DEBUG only feature, so maybe forcing or requiring
BMV_IF_DELALLOC there would make a whole lot of sense.
next prev parent reply other threads:[~2023-03-28 1:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 14:02 [PATCH] xfs: fix BUG_ON in xfs_getbmap() Ye Bin
2023-03-27 15:15 ` Darrick J. Wong
2023-03-28 1:33 ` yebin (H)
2023-03-28 1:43 ` Darrick J. Wong
2023-03-28 1:47 ` Christoph Hellwig
2023-03-28 2:03 ` Darrick J. Wong
2023-03-28 2:58 ` Dave Chinner
2023-03-28 1:44 ` Christoph Hellwig
2023-03-28 1:49 ` Christoph Hellwig [this message]
2023-03-27 17:30 ` kernel test robot
2023-03-27 20:14 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCJHotVOmvK+/P/k@infradead.org \
--to=hch@infradead.org \
--cc=djwong@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=yebin10@huawei.com \
--cc=yebin@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox