From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: cem@kernel.org, linux-xfs@vger.kernel.org, david@fromorbit.com
Subject: Re: [PATCH 4/6] xfs_db: fix metadump name obfuscation for ascii-ci filesystems
Date: Mon, 10 Apr 2023 21:58:46 -0700 [thread overview]
Message-ID: <ZDTpBtMlSsxRJjRh@infradead.org> (raw)
In-Reply-To: <168073979582.1656666.4211101901014947969.stgit@frogsfrogsfrogs>
On Wed, Apr 05, 2023 at 05:09:55PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Now that we've stabilized the dirent hash function for ascii-ci
> filesystems, adapt the metadump name obfuscation code to detect when
> it's obfuscating a directory entry name on an ascii-ci filesystem and
> spit out names that actually have the same hash.
Between the alloc use, the goto jumping back and the failure to
obsfucate some names this really seems horribly ugly. I could
come up with ideas to fix some of that, but they'd be fairly invasive.
Is there any reason we need to support obsfucatation for ascii-ci,
or could we just say we require "-o" to metadump ascii-ci file systems
and not deal with this at all given that it never actually worked?
next prev parent reply other threads:[~2023-04-11 4:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-06 0:02 [PATCHSET v2 0/4] xfs: fix ascii-ci problems, then kill it Darrick J. Wong
2023-04-06 0:02 ` [PATCH 1/4] xfs: stabilize the dirent name transformation function used for ascii-ci dir hash computation Darrick J. Wong
2023-04-11 4:50 ` Christoph Hellwig
2023-04-06 0:03 ` [PATCH 2/4] xfs: test the ascii case-insensitive hash Darrick J. Wong
2023-04-11 4:50 ` Christoph Hellwig
2023-04-06 0:03 ` [PATCH 3/4] xfs: use the directory name hash function for dir scrubbing Darrick J. Wong
2023-04-11 4:51 ` Christoph Hellwig
2023-04-06 0:03 ` [PATCH 4/4] xfs: deprecate the ascii-ci feature Darrick J. Wong
2023-04-11 4:52 ` Christoph Hellwig
2023-04-06 0:09 ` [PATCHSET v2 0/6] xfsprogs: fix ascii-ci problems, then kill it Darrick J. Wong
2023-04-06 0:09 ` [PATCH 1/6] xfs: stabilize the dirent name transformation function used for ascii-ci dir hash computation Darrick J. Wong
2023-04-06 0:09 ` [PATCH 2/6] xfs: test the ascii case-insensitive hash Darrick J. Wong
2023-04-06 0:09 ` [PATCH 3/6] xfs_db: move obfuscate_name assertion to callers Darrick J. Wong
2023-04-11 4:52 ` Christoph Hellwig
2023-04-06 0:09 ` [PATCH 4/6] xfs_db: fix metadump name obfuscation for ascii-ci filesystems Darrick J. Wong
2023-04-11 4:58 ` Christoph Hellwig [this message]
2023-04-11 15:35 ` Darrick J. Wong
2023-04-12 12:09 ` Christoph Hellwig
2023-04-12 22:04 ` Darrick J. Wong
2023-04-06 0:10 ` [PATCH 5/6] mkfs.xfs.8: warn about the version=ci feature Darrick J. Wong
2023-04-11 4:59 ` Christoph Hellwig
2023-04-06 0:10 ` [PATCH 6/6] mkfs: deprecate the ascii-ci feature Darrick J. Wong
2023-04-11 4:59 ` Christoph Hellwig
2023-04-13 15:19 ` [RFC PATCH 7/6] xfs_db: hoist name obfuscation code out of metadump.c Darrick J. Wong
2023-04-13 15:20 ` [RFC PATCH 8/6] xfs_db: create dirents and xattrs with colliding names Darrick J. Wong
2023-04-06 0:11 ` [PATCH] fstests: add a couple more tests for ascii-ci problems Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZDTpBtMlSsxRJjRh@infradead.org \
--to=hch@infradead.org \
--cc=cem@kernel.org \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox