Re: [PATCH 4/6] xfs_db: fix metadump name obfuscation for ascii-ci filesystems

Christoph Hellwig
2023-04-11T04:59:00Z

On Wed, Apr 05, 2023 at 05:09:55PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Now that we've stabilized the dirent hash function for ascii-ci
> filesystems, adapt the metadump name obfuscation code to detect when
> it's obfuscating a directory entry name on an ascii-ci filesystem and
> spit out names that actually have the same hash.

Between the alloc use, the goto jumping back and the failure to
obsfucate some names this really seems horribly ugly. I could
come up with ideas to fix some of that, but they'd be fairly invasive.

Is there any reason we need to support obsfucatation for ascii-ci,
or could we just say we require "-o" to metadump ascii-ci file systems
and not deal with this at all given that it never actually worked?