public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Justin Forbes <jforbes@fedoraproject.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Mike Pastore <mike@oobak.org>, linux-xfs@vger.kernel.org
Subject: Re: Corruption of in-memory data (0x8) detected at xfs_defer_finish_noroll on kernel 6.3
Date: Tue, 23 May 2023 16:32:11 -0500	[thread overview]
Message-ID: <ZG0w21hcYEl64joP@fedora64.linuxtx.org> (raw)
In-Reply-To: <20230502231318.GB3223426@dread.disaster.area>

On Wed, May 03, 2023 at 09:13:18AM +1000, Dave Chinner wrote:
> On Tue, May 02, 2023 at 05:13:09PM -0500, Mike Pastore wrote:
> > On Tue, May 2, 2023, 5:03 PM Dave Chinner <david@fromorbit.com> wrote:
> > 
> > >
> > > If you can find a minimal reproducer, that would help a lot in
> > > diagnosing the issue.
> > >
> > 
> > This is great, thank you. I'll get to work.
> > 
> > One note: the problem occured with and without crc=0, so we can rule that
> > out at least.
> 
> Yes, I noticed that. My point was more that we have much more
> confidence in crc=1 filesystems because they have much more robust
> verification of the on-disk format and won't fail log recovery in
> the way you noticed. The verification with crc=1 configured
> filesystems is also known to catch issues caused by
> memory corruption more frequently, often preventing such occurrences
> from corrupting the on-disk filesystem.
> 
> Hence if you are seeing corruption events, you really want to be
> using "-m crc=1" (default config) filesystems...

Upon trying to roll out 6.3.3 to Fedora users, it seems that we have a
few hitting this reliabily with 6.3 kernels. It is certainly not all
users of XFS though, as I use it extensively and haven't run across it.
The most responsive users who can reproduce all seem to be running on
xfs filesystems that were created a few years ago, and some even can't
reproduce it on their newer systems.  Either way, it is a widespread
enough problem that I can't roll out 6.3 kernels to stable releases
until it is fixed.

https://bugzilla.redhat.com/show_bug.cgi?id=2208553

Justin

> 
> Cheers,
> 
> Dave.
> -- 
> Dave Chinner
> david@fromorbit.com
> 

  reply	other threads:[~2023-05-23 21:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-02 19:14 Corruption of in-memory data (0x8) detected at xfs_defer_finish_noroll on kernel 6.3 Mike Pastore
2023-05-02 22:02 ` Dave Chinner
     [not found]   ` <CAP_NaWZEcv3B0nPEFguxVuQ8m93mO7te-bZDfwo-C8eN+f_KNA@mail.gmail.com>
2023-05-02 23:13     ` Dave Chinner
2023-05-23 21:32       ` Justin Forbes [this message]
2023-05-24  5:42         ` Dave Chinner
2023-05-25  2:24         ` Eric Sandeen
2023-05-25  2:15 ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZG0w21hcYEl64joP@fedora64.linuxtx.org \
    --to=jforbes@fedoraproject.org \
    --cc=david@fromorbit.com \
    --cc=linux-xfs@vger.kernel.org \
    --cc=mike@oobak.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox