From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 572A8C77B7A for ; Thu, 18 May 2023 05:41:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230002AbjERFlC (ORCPT ); Thu, 18 May 2023 01:41:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229549AbjERFlB (ORCPT ); Thu, 18 May 2023 01:41:01 -0400 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D04C82D43 for ; Wed, 17 May 2023 22:40:59 -0700 (PDT) Received: by mail-pg1-x535.google.com with SMTP id 41be03b00d2f7-5304913530fso1483568a12.0 for ; Wed, 17 May 2023 22:40:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20221208.gappssmtp.com; s=20221208; t=1684388459; x=1686980459; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lEffvrInPxS782GT1vsjQl+diWdb2xyAJ3axmrr9Dac=; b=CgaGaxfFVrxC91/0Fkb25Pz2glzPt1nbr61Q3ZzzEZ54VXbtem0AQ56w86YLb17bwO qhoEDW6nF9o4NpmPZvkJu/SZc6KhwUm5x3mifidEVnGeRVOEa41xddNJN6mwHEx8drYT fvDQuRt5XUJdlQI4iNuScocwM1ZEwVmG8QB7d+YCIm2OOaYIt/DeOhLUUpkmqiIh+NP3 wbTDxMmwo8bXPHCt24rr78dRyDK7XrCbnyZhU4ZMZLnvMwR/NZruqBn/nxeKvFBFW+4C DY7uQlX0O8l1RkiJDMSAL1U8u4EUdp5qBsUXe47RoK7wzvt7r0hZRYXFpz6uR/C8uVDM 5iqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684388459; x=1686980459; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lEffvrInPxS782GT1vsjQl+diWdb2xyAJ3axmrr9Dac=; b=llneFsqOJ7n4KKTSJGmdNkxK+47cUcW+CQ9pms+QufWmgPmmWCEkkuIPw+3+K5pY/0 T3DLitBBNclisKodcc5nifpZHwILUubd8k3wa6mzKAOom8qv1sNwYUNwWVZrvCCDYfWH yBKzWH4JS2XdB3BK6FvifpKBGoyIozcg2XNvG0JsTqKFyZRr/pGUIDcVJe0csIgHbfWX B8pdDxw88cDzVPXKrL0Fo2EqYwpNk8ExaM5ZFVkoDC1sEd+Aj40S3WBQl91e4UfPZeih hzpGzQb8ossAHXawkTu07KvtOpAuZlVtbyi7Xuvm5Ph+zvEl1ZZq+40jP6B3k4A4ItDd 9ocQ== X-Gm-Message-State: AC+VfDw1l7cFeDF9p+RmyCAeIXPIYCgXLuvJ47X/nfpbaZ2LT8cQ9wh6 LyXvJdHV7k7Ik0pxhK+DudC8Ig== X-Google-Smtp-Source: ACHHUZ6xti2fYNQIgKO/wNsn2B1J0IDZ9hVUm0X4uTC5UvVWRs7QkVtPS7VSnttDntyMu4lbqI01cw== X-Received: by 2002:a17:902:db0c:b0:1ae:6135:a050 with SMTP id m12-20020a170902db0c00b001ae6135a050mr1810118plx.19.1684388459359; Wed, 17 May 2023 22:40:59 -0700 (PDT) Received: from dread.disaster.area (pa49-179-0-188.pa.nsw.optusnet.com.au. [49.179.0.188]) by smtp.gmail.com with ESMTPSA id iy1-20020a170903130100b0019309be03e7sm399576plb.66.2023.05.17.22.40.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 22:40:58 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1pzWNj-000psy-2e; Thu, 18 May 2023 15:40:55 +1000 Date: Thu, 18 May 2023 15:40:55 +1000 From: Dave Chinner To: Christoph Hellwig Cc: Jens Axboe , Al Viro , Christian Brauner , "Darrick J. Wong" , Jan Kara , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH 13/13] xfs: wire up the ->mark_dead holder operation for log and RT devices Message-ID: References: <20230518042323.663189-1-hch@lst.de> <20230518042323.663189-14-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230518042323.663189-14-hch@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Thu, May 18, 2023 at 06:23:22AM +0200, Christoph Hellwig wrote: > Implement a set of holder_ops that shut down the file system when the > block device used as log or RT device is removed undeneath the file > system. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Darrick J. Wong > --- > fs/xfs/xfs_super.c | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c > index eb469b8f9a0497..75d37bbc5415fc 100644 > --- a/fs/xfs/xfs_super.c > +++ b/fs/xfs/xfs_super.c > @@ -377,6 +377,17 @@ xfs_setup_dax_always( > return 0; > } > > +static void > +xfs_hop_mark_dead( > + struct block_device *bdev) I'd prefer these ops to be named "xfs_bdev_...." to indicate the are fs bdev methods similar to how the super ops use "xfs_fs_...." to indicate they are fs superblock methods.... Other that this this is fine. Cheers, Dave. -- Dave Chinner david@fromorbit.com