From: Dave Chinner <david@fromorbit.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
Zorro Lang <zlang@redhat.com>,
linux-xfs@vger.kernel.org,
"Eric W. Biederman" <ebiederm@xmission.com>,
Mike Christie <michael.christie@oracle.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [6.5-rc5 regression] core dump hangs (was Re: [Bug report] fstests generic/051 (on xfs) hang on latest linux v6.5-rc5+)
Date: Mon, 12 Jun 2023 15:49:08 +1000 [thread overview]
Message-ID: <ZIax1FLfNajWk25A@dread.disaster.area> (raw)
In-Reply-To: <CAHk-=wgwJptCbaHwt+TpGgh04fTVAHd60AY3Jj1rX+Spf0fVyg@mail.gmail.com>
On Sun, Jun 11, 2023 at 10:34:29PM -0700, Linus Torvalds wrote:
> On Sun, Jun 11, 2023 at 10:16 PM Dave Chinner <david@fromorbit.com> wrote:
> >
> > > + /* vhost workers don't participate in core dups */
> > > + if ((current->flags & (PF_IO_WORKER | PF_USER_WORKER)) != PF_USER_WORKER)
> > > + goto out;
> > > +
> >
> > That would appear to make things worse. mkfs.xfs hung in Z state on
> > exit and never returned to the shell.
>
> Well, duh, that's because I'm a complete nincompoop who just copied
> the condition from the other cases, but those other cases were for
> testing the "this is *not* a vhost worker".
>
> Here the logic - as per the comment I added - was supposed to be "is
> this a vhost worker".
>
> So that "!=" should obviously have been a "==".
Same as without the condition - all the fsstress tasks hang in
do_coredump().
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2023-06-12 5:50 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-11 12:48 [Bug report] fstests generic/051 (on xfs) hang on latest linux v6.5-rc5+ Zorro Lang
2023-06-11 13:40 ` Zorro Lang
2023-06-11 23:01 ` Dave Chinner
2023-06-12 1:51 ` Darrick J. Wong
2023-06-12 2:21 ` [6.5-rc5 regression] core dump hangs (was Re: [Bug report] fstests generic/051 (on xfs) hang on latest linux v6.5-rc5+) Dave Chinner
2023-06-12 3:14 ` Linus Torvalds
2023-06-12 5:16 ` Dave Chinner
2023-06-12 5:34 ` Linus Torvalds
2023-06-12 5:49 ` Dave Chinner [this message]
2023-06-12 6:11 ` Linus Torvalds
2023-06-12 8:45 ` Eric W. Biederman
2023-06-12 9:30 ` Zorro Lang
2023-06-12 11:27 ` Dave Chinner
2023-06-12 6:36 ` Zorro Lang
2023-06-12 15:36 ` Darrick J. Wong
2023-06-12 15:52 ` Eric W. Biederman
2023-06-12 15:56 ` Linus Torvalds
2023-06-12 16:27 ` Jens Axboe
2023-06-12 16:38 ` Jens Axboe
2023-06-12 16:42 ` Linus Torvalds
2023-06-12 16:45 ` Jens Axboe
2023-06-12 16:57 ` Linus Torvalds
2023-06-12 17:11 ` Eric W. Biederman
2023-06-12 17:30 ` Jens Axboe
2023-06-12 17:29 ` Jens Axboe
2023-06-12 17:51 ` Linus Torvalds
2023-06-12 17:53 ` Jens Axboe
2023-06-12 17:56 ` Linus Torvalds
2023-06-12 18:34 ` Linus Torvalds
2023-06-12 23:33 ` Dave Chinner
2023-06-12 16:45 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIax1FLfNajWk25A@dread.disaster.area \
--to=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=michael.christie@oracle.com \
--cc=mst@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox