Re: [PATCH v3 8/8] iomap: Copy larger chunks from userspace

Matthew Wilcox
2023-07-10T03:57:45Z

On Mon, Jun 19, 2023 at 06:09:42PM +0100, Matthew Wilcox wrote:
> > > @@ -835,6 +837,8 @@ static loff_t iomap_write_iter(struct iomap_iter *iter, struct iov_iter *i)
> > > */
> > > if (copied)
> > > bytes = copied;
> >
> > I think with your code change which changes the label position of
> > "again", the above lines doing bytes = copied becomes dead code.
> > We anyway recalculate bytes after "again" label.
>
> Yes, you're right. Removed. I had a good think about whether this
> forgotten removal meant an overlooked problem, but I can't see one.

... also, removing this means that 'goto again' has the same effect as
'continue' ... which means we can actually restructure the loop slightly
and avoid the again label, the goto and even the continue. Patch to
follow in a few hours.