From: Dave Chinner <david@fromorbit.com>
To: Zhang Yi <yi.zhang@huaweicloud.com>
Cc: linux-xfs@vger.kernel.org, djwong@kernel.org,
dchinner@redhat.com, yi.zhang@huawei.com, leo.lilong@huawei.com,
yukuai3@huawei.com
Subject: Re: [PATCH 0/2] xfs: fix an inconsistency issue
Date: Tue, 13 Jun 2023 13:44:18 +1000 [thread overview]
Message-ID: <ZIfmEtB5ibbYsIZ8@dread.disaster.area> (raw)
In-Reply-To: <20230613030434.2944173-1-yi.zhang@huaweicloud.com>
On Tue, Jun 13, 2023 at 11:04:32AM +0800, Zhang Yi wrote:
> From: Zhang Yi <yi.zhang@huawei.com>
>
> This patch set fix a xattr inconsistency issue which lead to clean
> iunlinks failure.
So many questions, so few answers....
What inconsistency?
What's the signature of the failure that occurs?
What is the real world impact of the issue?
How do we reproduce it?
How did you test the fix?
After reading the cover letter for a patch series, I should know
the answers to all these questions (and more).
-Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2023-06-13 3:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 3:04 [PATCH 0/2] xfs: fix an inconsistency issue Zhang Yi
2023-06-13 3:04 ` [PATCH 1/2] xfs: factor out __xfs_da3_node_read() Zhang Yi
2023-06-13 3:04 ` [PATCH 2/2] xfs: atomic drop extent entries when inactiving attr Zhang Yi
2023-06-13 4:48 ` Dave Chinner
2023-06-13 3:44 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIfmEtB5ibbYsIZ8@dread.disaster.area \
--to=david@fromorbit.com \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=leo.lilong@huawei.com \
--cc=linux-xfs@vger.kernel.org \
--cc=yi.zhang@huawei.com \
--cc=yi.zhang@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox