From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: AGF length has never been bounds checked
Date: Fri, 16 Jun 2023 00:41:48 -0700 [thread overview]
Message-ID: <ZIwSPLeduXQwzmsU@infradead.org> (raw)
In-Reply-To: <20230616015906.3813726-1-david@fromorbit.com>
On Fri, Jun 16, 2023 at 11:59:06AM +1000, Dave Chinner wrote:
> + if (!(XFS_AGF_GOOD_VERSION(be32_to_cpu(agf->agf_versionnum))))
This has a superflous set of braces that can be dropped.
> + /*
> + * during growfs operations, the perag is not fully initialised,
Missing captialization for the first word. (And yes I noticed this
just moved, but we might as well fix it up while at it).
Otherwise this looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2023-06-16 7:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 1:59 [PATCH] xfs: AGF length has never been bounds checked Dave Chinner
2023-06-16 4:19 ` Darrick J. Wong
2023-06-16 6:34 ` Dave Chinner
2023-06-16 7:41 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIwSPLeduXQwzmsU@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox