* [PATCH] po/de.po: Fix possible typo which makes gettext-0.22 unhappy
@ 2023-06-21 10:55 Lars Wendler
2023-06-21 11:29 ` Holger Hoffstätte
0 siblings, 1 reply; 7+ messages in thread
From: Lars Wendler @ 2023-06-21 10:55 UTC (permalink / raw)
To: linux-xfs; +Cc: Lars Wendler
See downstream bug report: https://bugs.gentoo.org/908864
Signed-off-by: Lars Wendler <polynomial-c@gmx.de>
---
po/de.po | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/po/de.po b/po/de.po
index 944b0e91..a6f8fde1 100644
--- a/po/de.po
+++ b/po/de.po
@@ -3084,7 +3084,7 @@ msgstr "%llu Spezialdateien\n"
#: .././estimate/xfs_estimate.c:191
#, c-format
msgid "%s will take about %.1f megabytes\n"
-msgstr "%s wird etwa %.lf Megabytes einnehmen\n"
+msgstr "%s wird etwa %.1f Megabytes einnehmen\n"
#: .././estimate/xfs_estimate.c:198
#, c-format
--
2.41.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] po/de.po: Fix possible typo which makes gettext-0.22 unhappy
2023-06-21 10:55 [PATCH] po/de.po: Fix possible typo which makes gettext-0.22 unhappy Lars Wendler
@ 2023-06-21 11:29 ` Holger Hoffstätte
2023-06-21 11:56 ` Lars Wendler
0 siblings, 1 reply; 7+ messages in thread
From: Holger Hoffstätte @ 2023-06-21 11:29 UTC (permalink / raw)
To: Lars Wendler, linux-xfs
On 2023-06-21 12:55, Lars Wendler wrote:
> diff --git a/po/de.po b/po/de.po
> index 944b0e91..a6f8fde1 100644
> --- a/po/de.po
> +++ b/po/de.po
> @@ -3084,7 +3084,7 @@ msgstr "%llu Spezialdateien\n"
> #: .././estimate/xfs_estimate.c:191
> #, c-format
> msgid "%s will take about %.1f megabytes\n"
> -msgstr "%s wird etwa %.lf Megabytes einnehmen\n"
> +msgstr "%s wird etwa %.1f Megabytes einnehmen\n"
I don't see the difference..?
Both the added and removed line are the same.
-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] po/de.po: Fix possible typo which makes gettext-0.22 unhappy
2023-06-21 11:29 ` Holger Hoffstätte
@ 2023-06-21 11:56 ` Lars Wendler
2023-06-21 12:22 ` Holger Hoffstätte
2023-06-21 21:58 ` Dave Chinner
0 siblings, 2 replies; 7+ messages in thread
From: Lars Wendler @ 2023-06-21 11:56 UTC (permalink / raw)
To: Holger Hoffstätte; +Cc: linux-xfs
Am Wed, 21 Jun 2023 13:29:03 +0200
schrieb Holger Hoffstätte <holger@applied-asynchrony.com>:
> On 2023-06-21 12:55, Lars Wendler wrote:
> > diff --git a/po/de.po b/po/de.po
> > index 944b0e91..a6f8fde1 100644
> > --- a/po/de.po
> > +++ b/po/de.po
> > @@ -3084,7 +3084,7 @@ msgstr "%llu Spezialdateien\n"
> > #: .././estimate/xfs_estimate.c:191
> > #, c-format
> > msgid "%s will take about %.1f megabytes\n"
> > -msgstr "%s wird etwa %.lf Megabytes einnehmen\n"
> > +msgstr "%s wird etwa %.1f Megabytes einnehmen\n"
>
> I don't see the difference..?
> Both the added and removed line are the same.
>
> -h
I suppose depending on the font, it's quite hard to distinguish the two
lines.
The removed line contains "%.lf" with a lowercase letter L.
The added line contains "%.1f" where the lowercase letter L was replaced
with the digit 1.
Cheers
Lars
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] po/de.po: Fix possible typo which makes gettext-0.22 unhappy
2023-06-21 11:56 ` Lars Wendler
@ 2023-06-21 12:22 ` Holger Hoffstätte
2023-06-21 21:58 ` Dave Chinner
1 sibling, 0 replies; 7+ messages in thread
From: Holger Hoffstätte @ 2023-06-21 12:22 UTC (permalink / raw)
To: Lars Wendler; +Cc: linux-xfs
On 2023-06-21 13:56, Lars Wendler wrote:
> Am Wed, 21 Jun 2023 13:29:03 +0200
> schrieb Holger Hoffstätte <holger@applied-asynchrony.com>:
>
>> On 2023-06-21 12:55, Lars Wendler wrote:
>>> diff --git a/po/de.po b/po/de.po
>>> index 944b0e91..a6f8fde1 100644
>>> --- a/po/de.po
>>> +++ b/po/de.po
>>> @@ -3084,7 +3084,7 @@ msgstr "%llu Spezialdateien\n"
>>> #: .././estimate/xfs_estimate.c:191
>>> #, c-format
>>> msgid "%s will take about %.1f megabytes\n"
>>> -msgstr "%s wird etwa %.lf Megabytes einnehmen\n"
>>> +msgstr "%s wird etwa %.1f Megabytes einnehmen\n"
>>
>> I don't see the difference..?
>> Both the added and removed line are the same.
>>
>> -h
>
> I suppose depending on the font, it's quite hard to distinguish the two
> lines.
> The removed line contains "%.lf" with a lowercase letter L.
> The added line contains "%.1f" where the lowercase letter L was replaced
> with the digit 1.
Ahh..of course! Zooming in did the trick, I see the difference now.
Thanks!
-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] po/de.po: Fix possible typo which makes gettext-0.22 unhappy
2023-06-21 11:56 ` Lars Wendler
2023-06-21 12:22 ` Holger Hoffstätte
@ 2023-06-21 21:58 ` Dave Chinner
2023-06-22 5:23 ` [PATCH] xfsprogs: " Lars Wendler
1 sibling, 1 reply; 7+ messages in thread
From: Dave Chinner @ 2023-06-21 21:58 UTC (permalink / raw)
To: Lars Wendler; +Cc: Holger Hoffstätte, linux-xfs
On Wed, Jun 21, 2023 at 01:56:08PM +0200, Lars Wendler wrote:
> Am Wed, 21 Jun 2023 13:29:03 +0200
> schrieb Holger Hoffstätte <holger@applied-asynchrony.com>:
>
> > On 2023-06-21 12:55, Lars Wendler wrote:
> > > diff --git a/po/de.po b/po/de.po
> > > index 944b0e91..a6f8fde1 100644
> > > --- a/po/de.po
> > > +++ b/po/de.po
> > > @@ -3084,7 +3084,7 @@ msgstr "%llu Spezialdateien\n"
> > > #: .././estimate/xfs_estimate.c:191
> > > #, c-format
> > > msgid "%s will take about %.1f megabytes\n"
> > > -msgstr "%s wird etwa %.lf Megabytes einnehmen\n"
> > > +msgstr "%s wird etwa %.1f Megabytes einnehmen\n"
> >
> > I don't see the difference..?
> > Both the added and removed line are the same.
> >
> > -h
>
> I suppose depending on the font, it's quite hard to distinguish the two
> lines.
I didn't see it, and the commit message doesn't explain anything,
either. Pointing to a bugzilla somewhere does not make a valid
commit message....
> The removed line contains "%.lf" with a lowercase letter L.
> The added line contains "%.1f" where the lowercase letter L was replaced
> with the digit 1.
... whereas this explains what the bug being fixed is, and allows the
reviewer to see the subtle change being made. i.e. you just wrote
the commit message that should have been in the patch in the first
place. :)
Can you please resend the fix with the commit message updated?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] xfsprogs: po/de.po: Fix possible typo which makes gettext-0.22 unhappy
2023-06-21 21:58 ` Dave Chinner
@ 2023-06-22 5:23 ` Lars Wendler
2023-06-22 5:29 ` Dave Chinner
0 siblings, 1 reply; 7+ messages in thread
From: Lars Wendler @ 2023-06-22 5:23 UTC (permalink / raw)
To: linux-xfs; +Cc: Lars Wendler
The removed line contains "%.lf" with a lowercase letter L.
The added line contains "%.1f" where the lowercase letter L was replaced
with the digit 1.
Signed-off-by: Lars Wendler <polynomial-c@gmx.de>
---
po/de.po | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/po/de.po b/po/de.po
index 944b0e91..a6f8fde1 100644
--- a/po/de.po
+++ b/po/de.po
@@ -3084,7 +3084,7 @@ msgstr "%llu Spezialdateien\n"
#: .././estimate/xfs_estimate.c:191
#, c-format
msgid "%s will take about %.1f megabytes\n"
-msgstr "%s wird etwa %.lf Megabytes einnehmen\n"
+msgstr "%s wird etwa %.1f Megabytes einnehmen\n"
#: .././estimate/xfs_estimate.c:198
#, c-format
--
2.41.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] xfsprogs: po/de.po: Fix possible typo which makes gettext-0.22 unhappy
2023-06-22 5:23 ` [PATCH] xfsprogs: " Lars Wendler
@ 2023-06-22 5:29 ` Dave Chinner
0 siblings, 0 replies; 7+ messages in thread
From: Dave Chinner @ 2023-06-22 5:29 UTC (permalink / raw)
To: Lars Wendler; +Cc: linux-xfs
On Thu, Jun 22, 2023 at 07:23:54AM +0200, Lars Wendler wrote:
> The removed line contains "%.lf" with a lowercase letter L.
> The added line contains "%.1f" where the lowercase letter L was replaced
> with the digit 1.
>
> Signed-off-by: Lars Wendler <polynomial-c@gmx.de>
> ---
> po/de.po | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/po/de.po b/po/de.po
> index 944b0e91..a6f8fde1 100644
> --- a/po/de.po
> +++ b/po/de.po
> @@ -3084,7 +3084,7 @@ msgstr "%llu Spezialdateien\n"
> #: .././estimate/xfs_estimate.c:191
> #, c-format
> msgid "%s will take about %.1f megabytes\n"
> -msgstr "%s wird etwa %.lf Megabytes einnehmen\n"
> +msgstr "%s wird etwa %.1f Megabytes einnehmen\n"
>
> #: .././estimate/xfs_estimate.c:198
> #, c-format
Thanks Lars, looks good!
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-06-22 5:29 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-21 10:55 [PATCH] po/de.po: Fix possible typo which makes gettext-0.22 unhappy Lars Wendler
2023-06-21 11:29 ` Holger Hoffstätte
2023-06-21 11:56 ` Lars Wendler
2023-06-21 12:22 ` Holger Hoffstätte
2023-06-21 21:58 ` Dave Chinner
2023-06-22 5:23 ` [PATCH] xfsprogs: " Lars Wendler
2023-06-22 5:29 ` Dave Chinner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox