From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D65DAEB64D7 for ; Wed, 28 Jun 2023 08:00:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231451AbjF1H7o (ORCPT ); Wed, 28 Jun 2023 03:59:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231462AbjF1H5j (ORCPT ); Wed, 28 Jun 2023 03:57:39 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CEA5358E for ; Wed, 28 Jun 2023 00:56:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MCDS6NmzyoRCV6IJnepJ+hjfjYnFg72qgWpC8ZlvMVQ=; b=g8J+bI6NjwHwO1Cv4qlDfT4RFU OSMunrAgiXxuWBijx+0G1yp7n60IEHda9L/vc+TmxsU5FIZeVuPKGOnoXBENCFstwCKVcv7DleqGC 6H7dwwhe1vSZrkkn4mj50Lbz1+6C0qUk+xCboBmqgREXs+vVLkAVTULt8e8mBQ3+QsSAIvHcbE4GF G60bEQFgh9yKy9upqXl29EmgzhhqCxZRP2wJIUsfre7lEdleivo6mnOx1NxqqxFnznHSSI1AohdRL 9DSZnUrut6OZTfjDCHZ9KtUZJakMFxSteqaTiX4moWYQDYKB3BFiecPYpc0BEFWsajogAPyZWISm1 b3RupZ/g==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qEON1-00EwCq-1q; Wed, 28 Jun 2023 06:09:39 +0000 Date: Tue, 27 Jun 2023 23:09:39 -0700 From: Christoph Hellwig To: Dave Chinner Cc: linux-xfs@vger.kernel.org Subject: Re: [PATCH 8/8] xfs: fix bounds check in xfs_defer_agfl_block() Message-ID: References: <20230627224412.2242198-1-david@fromorbit.com> <20230627224412.2242198-9-david@fromorbit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230627224412.2242198-9-david@fromorbit.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Wed, Jun 28, 2023 at 08:44:12AM +1000, Dave Chinner wrote: > From: Dave Chinner > > Need to happen before we allocate and then leak the xefi. Found by > coverity via an xfsprogs libxfs scan. ... and also fixes the type of the agbno argument, which probably should be here in the commit log. Otherwise looks good: Reviewed-by: Christoph Hellwig