From: Anthony Iliopoulos <ailiop@suse.com>
To: Jeff Layton <jlayton@kernel.org>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH v5 5/8] xfs: XFS_ICHGTIME_CREATE is unused
Date: Fri, 14 Jul 2023 01:53:14 +0200 [thread overview]
Message-ID: <ZLCOaj3Xo0CWL3t2@technoir> (raw)
In-Reply-To: <20230713-mgctime-v5-5-9eb795d2ae37@kernel.org>
On Thu, Jul 13, 2023 at 07:00:54PM -0400, Jeff Layton wrote:
> Nothing ever sets this flag, which makes sense since the create time is
> set at inode instantiation and is never changed. Remove it and the
> handling of it in xfs_trans_ichgtime.
It is currently used by xfs_repair during recreating the root inode and
the internal realtime inodes when needed (libxfs is exported to xfsprogs
so there are userspace consumers of this code).
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
> fs/xfs/libxfs/xfs_shared.h | 2 --
> fs/xfs/libxfs/xfs_trans_inode.c | 2 --
> 2 files changed, 4 deletions(-)
>
> diff --git a/fs/xfs/libxfs/xfs_shared.h b/fs/xfs/libxfs/xfs_shared.h
> index c4381388c0c1..8989fff21723 100644
> --- a/fs/xfs/libxfs/xfs_shared.h
> +++ b/fs/xfs/libxfs/xfs_shared.h
> @@ -126,8 +126,6 @@ void xfs_log_get_max_trans_res(struct xfs_mount *mp,
> */
> #define XFS_ICHGTIME_MOD 0x1 /* data fork modification timestamp */
> #define XFS_ICHGTIME_CHG 0x2 /* inode field change timestamp */
> -#define XFS_ICHGTIME_CREATE 0x4 /* inode create timestamp */
> -
>
> /*
> * Symlink decoding/encoding functions
> diff --git a/fs/xfs/libxfs/xfs_trans_inode.c b/fs/xfs/libxfs/xfs_trans_inode.c
> index 6b2296ff248a..0c9df8df6d4a 100644
> --- a/fs/xfs/libxfs/xfs_trans_inode.c
> +++ b/fs/xfs/libxfs/xfs_trans_inode.c
> @@ -68,8 +68,6 @@ xfs_trans_ichgtime(
> inode->i_mtime = tv;
> if (flags & XFS_ICHGTIME_CHG)
> inode_set_ctime_to_ts(inode, tv);
> - if (flags & XFS_ICHGTIME_CREATE)
> - ip->i_crtime = tv;
> }
>
> /*
>
> --
> 2.41.0
>
>
next prev parent reply other threads:[~2023-07-13 23:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 23:00 [PATCH v5 0/8] fs: implement multigrain timestamps Jeff Layton
2023-07-13 23:00 ` [PATCH v5 1/8] fs: pass the request_mask to generic_fillattr Jeff Layton
2023-07-13 23:00 ` [PATCH v5 2/8] fs: add infrastructure for multigrain timestamps Jeff Layton
2023-07-13 23:00 ` [PATCH v5 3/8] tmpfs: bump the mtime/ctime/iversion when page becomes writeable Jeff Layton
2023-07-13 23:00 ` [PATCH v5 4/8] tmpfs: add support for multigrain timestamps Jeff Layton
2023-07-13 23:00 ` [PATCH v5 5/8] xfs: XFS_ICHGTIME_CREATE is unused Jeff Layton
2023-07-13 23:53 ` Anthony Iliopoulos [this message]
2023-07-14 0:15 ` Jeff Layton
2023-07-14 6:35 ` Darrick J. Wong
2023-07-14 10:53 ` Jeff Layton
2023-07-14 14:16 ` Darrick J. Wong
2023-07-14 14:30 ` Jeff Layton
2023-07-13 23:00 ` [PATCH v5 6/8] xfs: switch to multigrain timestamps Jeff Layton
2023-07-19 1:35 ` Dave Chinner
2023-07-13 23:00 ` [PATCH v5 7/8] ext4: " Jeff Layton
2023-07-13 23:00 ` [PATCH v5 8/8] btrfs: convert " Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLCOaj3Xo0CWL3t2@technoir \
--to=ailiop@suse.com \
--cc=jlayton@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox