public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Bill O'Donnell <bodonnel@redhat.com>
To: cem@kernel.org
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH] mkfs: Update agsize description in the man page
Date: Mon, 18 Sep 2023 11:58:17 -0500	[thread overview]
Message-ID: <ZQiBqQbJ01JmHT56@redhat.com> (raw)
In-Reply-To: <20230918142604.390357-1-cem@kernel.org>

On Mon, Sep 18, 2023 at 04:26:04PM +0200, cem@kernel.org wrote:
> From: Carlos Maiolino <cem@kernel.org>
> 
> agsize value accept different suffixes, including filesystem blocks, so,
> replace "expressed in bytes" by "expressed as a multiple of filesystem
> blocks".
> 
> Suggested-by: Dave Chinner <david@fromorbit.com>
> Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>

Reviewed-by: Bill O'Donnell <bodonnel@redhat.com>

> ---
>  man/man8/mkfs.xfs.8.in | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/man/man8/mkfs.xfs.8.in b/man/man8/mkfs.xfs.8.in
> index 08bb92f65..96c07fc71 100644
> --- a/man/man8/mkfs.xfs.8.in
> +++ b/man/man8/mkfs.xfs.8.in
> @@ -352,12 +352,11 @@ This is an alternative to using the
>  .B agcount
>  suboption. The
>  .I value
> -is the desired size of the allocation group expressed in bytes
> -(usually using the
> +is the desired size of the allocation group expressed as a multiple of the
> +filesystem block size (usually using the
>  .BR m " or " g
>  suffixes).
> -This value must be a multiple of the filesystem block size, and
> -must be at least 16MiB, and no more than 1TiB, and may
> +It must be at least 16MiB, and no more than 1TiB, and may
>  be automatically adjusted to properly align with the stripe geometry.
>  The
>  .B agcount
> -- 
> 2.39.2
> 


  reply	other threads:[~2023-09-18 16:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-18 14:26 [PATCH] mkfs: Update agsize description in the man page cem
2023-09-18 16:58 ` Bill O'Donnell [this message]
2023-09-19  3:27 ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZQiBqQbJ01JmHT56@redhat.com \
    --to=bodonnel@redhat.com \
    --cc=cem@kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox