From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E90FCD493A for ; Thu, 21 Sep 2023 00:38:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229733AbjIUAi2 (ORCPT ); Wed, 20 Sep 2023 20:38:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229723AbjIUAi2 (ORCPT ); Wed, 20 Sep 2023 20:38:28 -0400 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A159DD for ; Wed, 20 Sep 2023 17:38:21 -0700 (PDT) Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-1c59c40b840so3317345ad.3 for ; Wed, 20 Sep 2023 17:38:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1695256701; x=1695861501; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=jMd1KRyDEvQHJgfGmaNgihRzYBqmhVKvC+CzE4oWItk=; b=FFpSRnPATnEb/+Y1pQyexh9atCnUu9eFdC9bx7xhJXmn34X+fXRiwfk67BClML5skb jSE+U7TNaVrstBvFacVrq/KOmh0FRK4vlu9xy/To+FJibmqcRXl58xfOJad2sRfWdAag ZCg8ixFC7MwLv1OzA8ZzsFJfw4JHnoawAAv5pXvI5UdUTWpKH3XpcPT08s5HPE0IxTP0 SeCxVKGdOC9rlBlLbPZxqpwHImq4kI5caSPv+gVZhvkQPsSNhFhTn6M3nMsyQSrBCBal uA/z3rs86C5hpaYcszxHChDgv4tCx6OWt0cjilG7Y8Opn0Q9vkyMQrtoPsM6wvJxGNG4 0i6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695256701; x=1695861501; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jMd1KRyDEvQHJgfGmaNgihRzYBqmhVKvC+CzE4oWItk=; b=T7sKzvOXhbuXTTDwxPPXq5EWfIerBEVhA682DrqCBKCilTRyair9FNkxVr5+IwujmA wnpOi4s2RL0C1ltcuG/AD5znXiiW6b3a/5aGp1/CZ2yQrUTmY2NbeOQIxAPb8oFB+dvQ /25T0KS0Rnm3bRR+fv3at2Kz3uQlocPpkkU+kSSPhijEs1QAKd2I0yznYtZ7NuteZiSW vXV3wzPL7WAH5yiI2f1zR8G81u+xhNTJd/HFlk0t+LWDudFg4AyHfMnlEgIZidT3geHf qlHVp0QO/WwWxlef07ok+sciZtva+I7O5SDfgKCCfeL4zyNwM1ICyL4JLIesit7LXZXi HeEg== X-Gm-Message-State: AOJu0Yy+4INmPXCBGId0AT1z0Z5u0jEXGiEhcBnSYdXXnwwIH3R0Plo2 54KxNlxidfySH1486dDYm/AkLw== X-Google-Smtp-Source: AGHT+IEzLBFMk3kEDzcaTGMq6sgJhldRQhr+5QWyOipuNTfWB8uF3/9WdBQ08yQlD0BAeEqi8ebKKg== X-Received: by 2002:a17:903:228b:b0:1bb:e71f:793c with SMTP id b11-20020a170903228b00b001bbe71f793cmr4666954plh.44.1695256700664; Wed, 20 Sep 2023 17:38:20 -0700 (PDT) Received: from dread.disaster.area (pa49-180-20-59.pa.nsw.optusnet.com.au. [49.180.20.59]) by smtp.gmail.com with ESMTPSA id ij27-20020a170902ab5b00b001bd41b70b65sm111056plb.49.2023.09.20.17.38.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Sep 2023 17:38:19 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1qj7hx-003RjF-0J; Thu, 21 Sep 2023 10:38:17 +1000 Date: Thu, 21 Sep 2023 10:38:17 +1000 From: Dave Chinner To: Aleksandr Nogikh Cc: Christoph Hellwig , syzbot , djwong@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, syzkaller-bugs@googlegroups.com, linux-block@vger.kernel.org Subject: Re: [syzbot] [xfs?] INFO: task hung in clean_bdev_aliases Message-ID: References: <000000000000e534bb0604959011@google.com> <20230908082846.GB9560@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Wed, Sep 20, 2023 at 10:56:56AM +0200, Aleksandr Nogikh wrote: > # set subsystems: iomap No. As I said when I originally reassigned this from XFS to the block subsystem, this is a regression caused by changes to the block device code. Just because that overall change was to use iomap for block devices, that doesn't make it an iomap regression or the responsibility of XFS or iomap maintainers to triage and fix this block device regression. > On Fri, Sep 8, 2023 at 10:28 AM Christoph Hellwig wrote: > > > > On Wed, Sep 06, 2023 at 07:20:15PM +0200, Aleksandr Nogikh wrote: > > > > > > The reason why syzbot marked this report as xfs is that, per > > > MAINTAINERS, fs/iomap/ points to linux-xfs@vger.kernel.org. I can > > > adjust the rules syzbot uses so that these are routed to "block". > > > > > > But should MAINTAINERS actually also not relate IOMAP FILESYSTEM > > > LIBRARY with xfs in this case? > > > > I'd tag it with iomap, as it's a different subsystem just sharing > > the mailing list. We also have iommu@lists.linux.dev for both the > > iommu and dma-mapping subsystems as a similar example. > > > > But what's also important for issues like this is that often the > > called library code (in this case iomap) if often not, or only > > partially at fault. So capturing the calling context (in this > > case block) might also be useful. Which is exactly what Christoph also said. Please don't conflate a discussion about the incorrect assignment by syzbot (i.e. associating iomap with XFS because of a shared mailing list) with the actual problem that was initially reported. So, set this back to the block subsystem where it actually belongs. #syz set subsystems: block -Dave -- Dave Chinner david@fromorbit.com