Re: [PATCH 1/1] xfs: fix reloading entire unlinked bucket lists

[Dave Chinner <david@fromorbit.com>]

On Mon, Sep 25, 2023 at 08:38:10AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> During review of the patcheset that provided reloading of the incore
> iunlink list, Dave made a few suggestions, and I updated the copy in my
> dev tree.  Unfortunately, I then got distracted by ... who even knows
> what ... and forgot to backport those changes from my dev tree to my
> release candidate branch.  I then sent multiple pull requests with stale
> patches, and that's what was merged into -rc3.
> 
> So.
> 
> This patch re-adds the use of an unlocked iunlink list check to
> determine if we want to allocate the resources to recreate the incore
> list.  Since lost iunlinked inodes are supposed to be rare, this change
> helps us avoid paying the transaction and AGF locking costs every time
> we open any inode.
> 
> This also re-adds the shutdowns on failure, and re-applies the
> restructuring of the inner loop in xfs_inode_reload_unlinked_bucket, and
> re-adds a requested comment about the quotachecking code.
> 
> Retain the original RVB tag from Dave since there's no code change from
> the last submission.
> 
> Fixes: 68b957f64fca1 ("xfs: load uncached unlinked inodes into memory on demand")
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> Reviewed-by: Dave Chinner <dchinner@redhat.com>
> ---
>  fs/xfs/xfs_export.c |   16 ++++++++++++----
>  fs/xfs/xfs_inode.c  |   48 +++++++++++++++++++++++++++++++++++-------------
>  fs/xfs/xfs_itable.c |    2 ++
>  fs/xfs/xfs_qm.c     |   15 ++++++++++++---
>  4 files changed, 61 insertions(+), 20 deletions(-)

Looks good.

-Dave.
-- 
Dave Chinner
david@fromorbit.com