From: Sasha Levin <sashal@kernel.org>
To: Leah Rumancik <leah.rumancik@gmail.com>
Cc: stable@vger.kernel.org, linux-xfs@vger.kernel.org,
amir73il@gmail.com, chandan.babu@oracle.com,
Dave Chinner <dchinner@redhat.com>,
"Darrick J . Wong" <djwong@kernel.org>
Subject: Re: [PATCH 5.15 1/6] xfs: bound maximum wait time for inodegc work
Date: Mon, 25 Sep 2023 15:12:23 -0400 [thread overview]
Message-ID: <ZRHbl0XZlpLBLU4H@sashalap> (raw)
In-Reply-To: <20230922010156.1718782-1-leah.rumancik@gmail.com>
On Thu, Sep 21, 2023 at 06:01:51PM -0700, Leah Rumancik wrote:
>From: Dave Chinner <dchinner@redhat.com>
>
>[ Upstream commit 7cf2b0f9611b9971d663e1fc3206eeda3b902922 ]
>
>Currently inodegc work can sit queued on the per-cpu queue until
>the workqueue is either flushed of the queue reaches a depth that
>triggers work queuing (and later throttling). This means that we
>could queue work that waits for a long time for some other event to
>trigger flushing.
>
>Hence instead of just queueing work at a specific depth, use a
>delayed work that queues the work at a bound time. We can still
>schedule the work immediately at a given depth, but we no long need
>to worry about leaving a number of items on the list that won't get
>processed until external events prevail.
>
>Signed-off-by: Dave Chinner <dchinner@redhat.com>
>Reviewed-by: Darrick J. Wong <djwong@kernel.org>
>Signed-off-by: Darrick J. Wong <djwong@kernel.org>
>Signed-off-by: Leah Rumancik <leah.rumancik@gmail.com>
>Acked-by: Darrick J. Wong <djwong@kernel.org>
Queued up all 6, thanks!
--
Thanks,
Sasha
prev parent reply other threads:[~2023-09-25 19:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 1:01 [PATCH 5.15 1/6] xfs: bound maximum wait time for inodegc work Leah Rumancik
2023-09-22 1:01 ` [PATCH 5.15 2/6] xfs: introduce xfs_inodegc_push() Leah Rumancik
2023-09-22 1:01 ` [PATCH 5.15 3/6] xfs: explicitly specify cpu when forcing inodegc delayed work to run immediately Leah Rumancik
2023-09-22 1:01 ` [PATCH 5.15 4/6] xfs: check that per-cpu inodegc workers actually run on that cpu Leah Rumancik
2023-09-22 1:01 ` [PATCH 5.15 5/6] xfs: disable reaping in fscounters scrub Leah Rumancik
2023-09-22 1:01 ` [PATCH 5.15 6/6] xfs: fix xfs_inodegc_stop racing with mod_delayed_work Leah Rumancik
2023-09-25 19:12 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRHbl0XZlpLBLU4H@sashalap \
--to=sashal@kernel.org \
--cc=amir73il@gmail.com \
--cc=chandan.babu@oracle.com \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=leah.rumancik@gmail.com \
--cc=linux-xfs@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).