From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90275E95A90 for ; Sun, 8 Oct 2023 21:54:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344697AbjJHVyf (ORCPT ); Sun, 8 Oct 2023 17:54:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344628AbjJHVyf (ORCPT ); Sun, 8 Oct 2023 17:54:35 -0400 Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF09CB3 for ; Sun, 8 Oct 2023 14:54:33 -0700 (PDT) Received: by mail-qk1-x731.google.com with SMTP id af79cd13be357-7741b18a06aso287768485a.1 for ; Sun, 08 Oct 2023 14:54:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1696802073; x=1697406873; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2lF92kcVMrLRaxlLOpuuihR9KaLnr39sEQyi5og8S4Q=; b=oRt5lRhGA45NWLfsNWFveCjvPYIMf1OGRPgqL71zdRrmtlZVVh8UgD9kFurup6Ba32 kVmzFQkQUe/B1kzt+HOR+/fQ/8iamOMvW1lj8MUNcLgfZLz+HK4Kwzq1lJpeHVKPS6Vh ynfOx/mmvv8Gkq14aSh9bwVMkOCx1WFNtkTtsrVolXVFToHSRNDRg6EuzvFKcO6VpuyN CL0H8NPh2NkDlHBcxjJ8NBh1GaKFxfjblpFDCEjM0gQDcqYOUhf1OXjua7cKFJPqDHnK cr3mD1RrZmZEIs1FcA/mcuQxbg7uuZxOTMtLNtzQSCGYflUT5mFMu49nXVaLUxRp5V4j NxAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696802073; x=1697406873; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2lF92kcVMrLRaxlLOpuuihR9KaLnr39sEQyi5og8S4Q=; b=ofxSvreMDQe0RYWjzgeMZzORggY6QaQqMPndhM6UqTIC+z4oeCUWHspkILlxM5Kfn+ SchiAttop9SDs6Gbvr/DlcyO18WYfU488omPrAu2wm0xMMr8Hu/WB4Xfpn61EDwOOitd L+Xs5iv0ZsdOW8q1ZULhAKBYLG7AaOzs6aiTllPckX57Krr5rnhEqbJomGJwiL5wJyGf PuoQpKSkOrytOTlSQPDzXmaTY/mo1KivcFYUlfx2UyUX4TP07uXG1MlBKeg4IkoK7i8X lsIMkpmOZaGIDdM6K4fu391LHs4eKaOdQz8SmiatZZERFGunJEE2Yw7ZjKa0cn5wnYV8 Z8OQ== X-Gm-Message-State: AOJu0YyTxCCRSIBz7QqzyJIjnB+yMrzzP6UW0szrkrktmCSbAebtsF2Z MW3rdP6o7SYm2zJmj2D+UkCz4A== X-Google-Smtp-Source: AGHT+IE9uk2jQHbCBVxRhP7NjawRCWYl0XIv9gecaHQ8PgPtfZNgekIL319uoZlVT8luWtvfdncaig== X-Received: by 2002:a05:620a:410a:b0:76c:bdbd:c51d with SMTP id j10-20020a05620a410a00b0076cbdbdc51dmr18146770qko.66.1696802072815; Sun, 08 Oct 2023 14:54:32 -0700 (PDT) Received: from dread.disaster.area (pa49-180-20-59.pa.nsw.optusnet.com.au. [49.180.20.59]) by smtp.gmail.com with ESMTPSA id e18-20020aa78c52000000b00686b649cdd0sm4991103pfd.86.2023.10.08.14.54.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Oct 2023 14:54:31 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1qpbjI-00BFzX-19; Mon, 09 Oct 2023 08:54:28 +1100 Date: Mon, 9 Oct 2023 08:54:28 +1100 From: Dave Chinner To: "Matthew Wilcox (Oracle)" Cc: Peter Zijlstra , Ingo Molnar , Will Deacon , Waiman Long , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Chandan Babu R , "Darrick J . Wong" , linux-xfs@vger.kernel.org, Mateusz Guzik Subject: Re: [PATCH v2 1/5] locking: Add rwsem_assert_held() and rwsem_assert_held_write() Message-ID: References: <20231007203543.1377452-1-willy@infradead.org> <20231007203543.1377452-2-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231007203543.1377452-2-willy@infradead.org> Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Sat, Oct 07, 2023 at 09:35:39PM +0100, Matthew Wilcox (Oracle) wrote: > Modelled after lockdep_assert_held() and lockdep_assert_held_write(), > but are always active, even when lockdep is disabled. Of course, they > don't test that _this_ thread is the owner, but it's sufficient to catch > many bugs and doesn't incur the same performance penalty as lockdep. > > Signed-off-by: Matthew Wilcox (Oracle) > --- ..... > @@ -169,6 +189,18 @@ static __always_inline int rwsem_is_contended(struct rw_semaphore *sem) > * the RT specific variant. > */ > > +static inline void rwsem_assert_held(const struct rw_semaphore *sem) > +{ > + lockdep_assert_held(sem); > + __rwsem_assert_held(sem); > +} if (IS_ENABLED(CONFIG_LOCKDEP)) lockdep_assert_held(sem); else __rwsem_assert_held(sem); -Dave. -- Dave Chinner david@fromorbit.com