From: Christoph Hellwig <hch@infradead.org>
To: Omar Sandoval <osandov@osandov.com>
Cc: linux-xfs@vger.kernel.org, "Darrick J . Wong" <djwong@kernel.org>,
kernel-team@fb.com, Prashant Nema <pnema@fb.com>
Subject: Re: [PATCH v2 6/6] xfs: don't look for end of extent further than necessary in xfs_rtallocate_extent_near()
Date: Mon, 9 Oct 2023 03:39:23 -0700 [thread overview]
Message-ID: <ZSPYW9mOy/PA34xD@infradead.org> (raw)
In-Reply-To: <44220273fdbc442e963bed1cfaa4707957b49326.1693950248.git.osandov@osandov.com>
On Tue, Sep 05, 2023 at 02:51:57PM -0700, Omar Sandoval wrote:
> + if (maxlog == 0)
> + maxblocks = 0;
> + else if (maxlog < mp->m_blkbit_log)
> + maxblocks = 1;
> + else
> + maxblocks = 2 << (maxlog - mp->m_blkbit_log);
Overly long line here (can be fixed when applying I guess).
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2023-10-09 10:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 21:51 [PATCH v2 0/6] xfs: CPU usage optimizations for realtime allocator Omar Sandoval
2023-09-05 21:51 ` [PATCH v2 1/6] xfs: cache last bitmap block in " Omar Sandoval
2023-09-08 3:43 ` Dave Chinner
2023-09-08 15:28 ` Darrick J. Wong
2023-09-14 21:48 ` Dave Chinner
2023-09-18 15:38 ` Darrick J. Wong
2023-10-09 10:34 ` Christoph Hellwig
2023-09-05 21:51 ` [PATCH v2 2/6] xfs: invert the realtime summary cache Omar Sandoval
2023-10-09 10:35 ` Christoph Hellwig
2023-09-05 21:51 ` [PATCH v2 3/6] xfs: return maximum free size from xfs_rtany_summary() Omar Sandoval
2023-10-09 10:35 ` Christoph Hellwig
2023-09-05 21:51 ` [PATCH v2 4/6] xfs: limit maxlen based on available space in xfs_rtallocate_extent_near() Omar Sandoval
2023-10-09 10:36 ` Christoph Hellwig
2023-09-05 21:51 ` [PATCH v2 5/6] xfs: don't try redundant allocations " Omar Sandoval
2023-10-09 10:38 ` Christoph Hellwig
2023-09-05 21:51 ` [PATCH v2 6/6] xfs: don't look for end of extent further than necessary " Omar Sandoval
2023-10-09 10:39 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSPYW9mOy/PA34xD@infradead.org \
--to=hch@infradead.org \
--cc=djwong@kernel.org \
--cc=kernel-team@fb.com \
--cc=linux-xfs@vger.kernel.org \
--cc=osandov@osandov.com \
--cc=pnema@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).