public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
	Catherine Hoang <catherine.hoang@oracle.com>,
	linux-xfs@vger.kernel.org
Subject: Re: [PATCH v3] xfs: allow read IO and FICLONE to run concurrently
Date: Thu, 12 Oct 2023 08:07:12 -0700	[thread overview]
Message-ID: <ZSgLoD0NWRH0bCGE@infradead.org> (raw)
In-Reply-To: <20231012150231.GE21298@frogsfrogsfrogs>

On Thu, Oct 12, 2023 at 08:02:31AM -0700, Darrick J. Wong wrote:
> Catherine started with this,
> https://lore.kernel.org/linux-xfs/8911B94D-DD29-4D6E-B5BC-32EAF1866245@oracle.com/
> 
> and the rest of us whittled it down to the single patch you see here.
> Sections 1-2 are still relevant; S3 was the path not taken.

I'd still take the core of that into the actual commit message.  This
part, maybe slightly rewored:

"One of our VM cluster management products needs to snapshot KVM image
files so that they can be restored in case of failure. Snapshotting is
done by redirecting VM disk writes to a sidecar file and using reflink
on the disk image, specifically the FICLONE ioctl as used by
"cp --reflink". Reflink locks the source and destination files while it
operates, which means that reads from the main vm disk image are blocked,
causing the vm to stall. When an image file is heavily fragmented, the
copy process could take several minutes. Some of the vm image files have
50-100 million extent records, and duplicating that much metadata locks
the file for 30 minutes or more. Having activities suspended for such
a long time in a cluster node could result in node eviction."


      reply	other threads:[~2023-10-12 15:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-12  1:08 [PATCH v3] xfs: allow read IO and FICLONE to run concurrently Catherine Hoang
2023-10-12  6:26 ` Darrick J. Wong
2023-10-12  8:34 ` Christoph Hellwig
2023-10-12 15:02   ` Darrick J. Wong
2023-10-12 15:07     ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZSgLoD0NWRH0bCGE@infradead.org \
    --to=hch@infradead.org \
    --cc=catherine.hoang@oracle.com \
    --cc=djwong@kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox