From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Catherine Hoang <catherine.hoang@oracle.com>,
linux-xfs@vger.kernel.org
Subject: Re: [RFC PATCH] generic: test reads racing with slow reflink operations
Date: Mon, 23 Oct 2023 09:20:31 +1100 [thread overview]
Message-ID: <ZTWgLzODbEIDHuKv@dread.disaster.area> (raw)
In-Reply-To: <20231020152248.GQ3195650@frogsfrogsfrogs>
On Fri, Oct 20, 2023 at 08:22:48AM -0700, Darrick J. Wong wrote:
> On Thu, Oct 19, 2023 at 11:09:49PM -0700, Christoph Hellwig wrote:
> > On Thu, Oct 19, 2023 at 01:09:13PM -0700, Darrick J. Wong wrote:
> > > permit reads, since the source file contents do not change. This is a
> >
> > duplicate white space before "not"
>
> Fixed.
>
> > > +#ifndef FICLONE
> > > +# define FICLONE _IOW(0x94, 9, int)
> > > +#endif
> >
> > Can't we assume system headers with FICLONE by now?
>
> That depends on the long tail of RHEL7. But you're right, it has been
> years now, I'll just kill this hunk and see who complains. :)
*cough*
Just add an autoconf rule, yes?
-Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2023-10-22 22:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 20:09 [RFC PATCH] generic: test reads racing with slow reflink operations Darrick J. Wong
2023-10-20 6:09 ` Christoph Hellwig
2023-10-20 15:22 ` Darrick J. Wong
2023-10-22 22:20 ` Dave Chinner [this message]
2023-10-20 13:37 ` Catherine Hoang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTWgLzODbEIDHuKv@dread.disaster.area \
--to=david@fromorbit.com \
--cc=catherine.hoang@oracle.com \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox