From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3BF7C4167B for ; Wed, 1 Nov 2023 19:01:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232442AbjKATBq (ORCPT ); Wed, 1 Nov 2023 15:01:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232643AbjKATBo (ORCPT ); Wed, 1 Nov 2023 15:01:44 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73D7311B for ; Wed, 1 Nov 2023 12:00:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698865256; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VV/0JSb4ahQ+qDeA+yAiFldg8WZK/uiwiHB5Saqdh+M=; b=Q5R7/OuvTeG40Y+sR28iglCNWkc+673AMnqKC1U6aigtqctkyPcAs/qf6K15VL/9l0l3Z9 Wpyv17TDoaJWGkPmadMy6V8ZSUCz5PMCFb8pFAa0dIHMDfZV5zXw8UPNxWwuBleiqNjeLd zU5whYVXlXrYST3LaswEoii4l16j+dA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-590-Y8YF_Nq8N7W0wYIgKZ9icA-1; Wed, 01 Nov 2023 15:00:48 -0400 X-MC-Unique: Y8YF_Nq8N7W0wYIgKZ9icA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F0CB98314FA; Wed, 1 Nov 2023 19:00:47 +0000 (UTC) Received: from bfoster (unknown [10.22.16.88]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 17CA410F52; Wed, 1 Nov 2023 19:00:47 +0000 (UTC) Date: Wed, 1 Nov 2023 15:01:22 -0400 From: Brian Foster To: Jan Kara Cc: Christian Brauner , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, Jens Axboe , Christoph Hellwig , Kees Cook , syzkaller , Alexander Popov , linux-xfs@vger.kernel.org, Dmitry Vyukov , Kent Overstreet , linux-bcachefs@vger.kernel.org Subject: Re: [PATCH 1/7] bcachefs: Convert to bdev_open_by_path() Message-ID: References: <20231101173542.23597-1-jack@suse.cz> <20231101174325.10596-1-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231101174325.10596-1-jack@suse.cz> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Wed, Nov 01, 2023 at 06:43:06PM +0100, Jan Kara wrote: > Convert bcachefs to use bdev_open_by_path() and pass the handle around. > > CC: Kent Overstreet > CC: Brian Foster > CC: linux-bcachefs@vger.kernel.org > Signed-off-by: Jan Kara > --- > fs/bcachefs/super-io.c | 19 ++++++++++--------- > fs/bcachefs/super_types.h | 1 + > 2 files changed, 11 insertions(+), 9 deletions(-) > > diff --git a/fs/bcachefs/super-io.c b/fs/bcachefs/super-io.c > index 332d41e1c0a3..01a32c41a540 100644 > --- a/fs/bcachefs/super-io.c > +++ b/fs/bcachefs/super-io.c ... > @@ -685,21 +685,22 @@ int bch2_read_super(const char *path, struct bch_opts *opts, > if (!opt_get(*opts, nochanges)) > sb->mode |= BLK_OPEN_WRITE; > > - sb->bdev = blkdev_get_by_path(path, sb->mode, sb->holder, &bch2_sb_handle_bdev_ops); > - if (IS_ERR(sb->bdev) && > - PTR_ERR(sb->bdev) == -EACCES && > + sb->bdev_handle = bdev_open_by_path(path, sb->mode, sb->holder, &bch2_sb_handle_bdev_ops); > + if (IS_ERR(sb->bdev_handle) && > + PTR_ERR(sb->bdev_handle) == -EACCES && > opt_get(*opts, read_only)) { > sb->mode &= ~BLK_OPEN_WRITE; > > - sb->bdev = blkdev_get_by_path(path, sb->mode, sb->holder, &bch2_sb_handle_bdev_ops); > - if (!IS_ERR(sb->bdev)) > + sb->bdev_handle = bdev_open_by_path(path, sb->mode, sb->holder, &bch2_sb_handle_bdev_ops); > + if (!IS_ERR(sb->bdev_handle)) > opt_set(*opts, nochanges, true); > } > > - if (IS_ERR(sb->bdev)) { > - ret = PTR_ERR(sb->bdev); > + if (IS_ERR(sb->bdev_handle)) { > + ret = PTR_ERR(sb->bdev_handle); > goto out; > } > + sb->bdev = sb->bdev_handle->bdev; > > ret = bch2_sb_realloc(sb, 0); > if (ret) { Hi Jan, This all seems reasonable to me, but should bcachefs use sb_open_mode() somewhere in here to involve use of the restrict writes flag in the first place? It looks like bcachefs sort of open codes bits of mount_bdev() so it isn't clear the flag would be used anywhere... Brian > diff --git a/fs/bcachefs/super_types.h b/fs/bcachefs/super_types.h > index 78d6138db62d..b77d8897c9fa 100644 > --- a/fs/bcachefs/super_types.h > +++ b/fs/bcachefs/super_types.h > @@ -4,6 +4,7 @@ > > struct bch_sb_handle { > struct bch_sb *sb; > + struct bdev_handle *bdev_handle; > struct block_device *bdev; > struct bio *bio; > void *holder; > -- > 2.35.3 >