From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FF12C4167B for ; Sun, 5 Nov 2023 18:28:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229475AbjKES2v (ORCPT ); Sun, 5 Nov 2023 13:28:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229451AbjKES2u (ORCPT ); Sun, 5 Nov 2023 13:28:50 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA5DBDD for ; Sun, 5 Nov 2023 10:28:47 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 441961F37C; Sun, 5 Nov 2023 18:28:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1699208924; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ejMj5GEbSslglgjpg9+rlHBIGSGEJxOItOp3VwLhYLk=; b=NjCumtTcLT3kTEGY02LZilGvy6GpsJ0dDTgGpv8mgK1nGCro0P+pyX+ymO1DgqYHXOmMA6 TuxlFqAaEMWBfiXwhhGEtByG4drBG2e+mcPe+kvJkRFzbzNt5k7hip0bxiBlepUaM9gf7C j0gzR8w1OOUlXLzztGmJmnBgoVoiTfc= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F04B813907; Sun, 5 Nov 2023 18:28:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id XVlYNtveR2UGLAAAMHmgww (envelope-from ); Sun, 05 Nov 2023 18:28:43 +0000 Date: Sun, 5 Nov 2023 19:28:43 +0100 From: Anthony Iliopoulos To: Holger =?iso-8859-1?Q?Hoffst=E4tte?= Cc: linux-xfs Subject: Re: XFS_DEBUG got enabled by default in 6.6 Message-ID: References: <308d32cc-4451-ad70-53bc-b41275023e45@applied-asynchrony.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <308d32cc-4451-ad70-53bc-b41275023e45@applied-asynchrony.com> Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Sun, Nov 05, 2023 at 07:03:55PM +0100, Holger Hoffstätte wrote: > Hello, > > I recently updated to 6.6 and was surprised to see that XFS_DEBUG suddenly > got enabled by default. This was apparently caused by commit d7a74cad8f45 > ("xfs: track usage statistics of online fsck") and a followup fix. Actually the follow-up fix 57c0f4a8ea3a ("xfs: fix select in config XFS_ONLINE_SCRUB_STATS") seems to be wrong, I think the original intention was to select DEBUG_FS rather than XFS_DEBUG, since the feature depends on debugfs to export those stats. Regards, Anthony