* XFS_DEBUG got enabled by default in 6.6
@ 2023-11-05 18:03 Holger Hoffstätte
2023-11-05 18:28 ` Anthony Iliopoulos
2023-11-05 22:40 ` Dave Chinner
0 siblings, 2 replies; 3+ messages in thread
From: Holger Hoffstätte @ 2023-11-05 18:03 UTC (permalink / raw)
To: linux-xfs
Hello,
I recently updated to 6.6 and was surprised to see that XFS_DEBUG suddenly
got enabled by default. This was apparently caused by commit d7a74cad8f45
("xfs: track usage statistics of online fsck") and a followup fix.
Was that intentional? From the description of XFS_DEBUG I gather it should
be disabled for regular use, so this was a bit surprising to see.
Maybe that "default y" setting should be removed.
thanks,
Holger
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: XFS_DEBUG got enabled by default in 6.6
2023-11-05 18:03 XFS_DEBUG got enabled by default in 6.6 Holger Hoffstätte
@ 2023-11-05 18:28 ` Anthony Iliopoulos
2023-11-05 22:40 ` Dave Chinner
1 sibling, 0 replies; 3+ messages in thread
From: Anthony Iliopoulos @ 2023-11-05 18:28 UTC (permalink / raw)
To: Holger Hoffstätte; +Cc: linux-xfs
On Sun, Nov 05, 2023 at 07:03:55PM +0100, Holger Hoffstätte wrote:
> Hello,
>
> I recently updated to 6.6 and was surprised to see that XFS_DEBUG suddenly
> got enabled by default. This was apparently caused by commit d7a74cad8f45
> ("xfs: track usage statistics of online fsck") and a followup fix.
Actually the follow-up fix 57c0f4a8ea3a ("xfs: fix select in config
XFS_ONLINE_SCRUB_STATS") seems to be wrong, I think the original
intention was to select DEBUG_FS rather than XFS_DEBUG, since the
feature depends on debugfs to export those stats.
Regards,
Anthony
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: XFS_DEBUG got enabled by default in 6.6
2023-11-05 18:03 XFS_DEBUG got enabled by default in 6.6 Holger Hoffstätte
2023-11-05 18:28 ` Anthony Iliopoulos
@ 2023-11-05 22:40 ` Dave Chinner
1 sibling, 0 replies; 3+ messages in thread
From: Dave Chinner @ 2023-11-05 22:40 UTC (permalink / raw)
To: Holger Hoffstätte; +Cc: linux-xfs
On Sun, Nov 05, 2023 at 07:03:55PM +0100, Holger Hoffstätte wrote:
> Hello,
>
> I recently updated to 6.6 and was surprised to see that XFS_DEBUG suddenly
> got enabled by default.
It should not be enabled by default - XFS_ONLINE_SCRUB defaults to
"n" and so XFS_ONLINE_SCRUB_STATS should not be enabled nor should
it be selecting XFS_DEBUG. So to see this, you have to turn on
XFS_ONLINE_SCRUB first....
> This was apparently caused by commit d7a74cad8f45
> ("xfs: track usage statistics of online fsck") and a followup fix.
> Was that intentional? From the description of XFS_DEBUG I gather it should
> be disabled for regular use, so this was a bit surprising to see.
> Maybe that "default y" setting should be removed.
No, it's just wrong....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-05 22:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-05 18:03 XFS_DEBUG got enabled by default in 6.6 Holger Hoffstätte
2023-11-05 18:28 ` Anthony Iliopoulos
2023-11-05 22:40 ` Dave Chinner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox