Re: [Bug report][fstests generic/047] Internal error !(flags & XFS_DABUF_MAP_HOLE_OK) at line 2572 of file fs/xfs/libxfs/xfs_da_btree.c. Caller xfs_dabuf_map.constprop.0+0x26c/0x368 [xfs]

[Dave Chinner <david@fromorbit.com>]

On Tue, Nov 07, 2023 at 04:05:22PM +0800, Zorro Lang wrote:
> On Tue, Nov 07, 2023 at 07:33:50AM +1100, Dave Chinner wrote:
> > On Tue, Nov 07, 2023 at 03:26:27AM +0800, Zorro Lang wrote:
> > > Thanks for your reply :) I tried to do a kernel bisect long time, but
> > > find nothing ... Then suddently, I found it's failed from a xfsprogs
> > > change [1].
> > > 
> > > Although that's not the root cause of this bug (on s390x), it just
> > > enabled "nrext64" by default, which I never tested on s390x before.
> > > For now, we know this's an issue about this feature, and only on
> > > s390x for now.
> > 
> > That's not good. Can you please determine if this is a zero-day bug
> > with the nrext64 feature? I think it was merged in 5.19, so if you
> > could try to reproduce it on a 5.18 and 5.19 kernels first, that
> > would be handy.
> 
> Unfortunately, it's a bug be there nearly from beginning. The linux v5.19
> can trigger this bug (with latest xfsprogs for-next branch):

Ok. Can you grab the pahole output for the xfs_dinode and
xfs_log_dinode for s390 from both 5.18 and 5.19 kernel builds?
(i.e. 'pahole fs/xfs/xfs_inode.o |less' and search for the two
structures).

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com