From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="zmRR7yRi" Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73918AD for ; Wed, 22 Nov 2023 22:42:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=bSyuy2Rbc2/IazR5iHXJPTI+mQPjlcC9ptsNZbrwUOE=; b=zmRR7yRilw8KOY7erXTtefesM8 bmjzcAssiFHeDHZ20JvpN+D3XO9FmM0JPQDuJzc4TwP1Zqx28lrzCeT3fAG6FbFGK2H0lraHNkwzK TsD+76Rl6eUKOEmSnoyL61mo+OGRIBEsPChlBceAsjzZZeXB1OveR2aNPB+Qtv5McsWTcLnVWKWVf LM/yL8jDgOb4UKkzykHUrj0jpELZCWOZU0ioWkQc6wBeVhgJYdjddAtkjMx59ugKURt7f+KlAvUHC 4i0x7VhNu4HbbxlFwFeosTUBsFR9gIWoevRRQ2Cjca2fXgmeyP2GJU+JZl5nBF9xy/J2Ukrv8eY05 Grp+M3fg==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1r63Q8-003w2n-17; Thu, 23 Nov 2023 06:42:40 +0000 Date: Wed, 22 Nov 2023 22:42:40 -0800 From: Christoph Hellwig To: "Darrick J. Wong" Cc: cem@kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH 8/9] xfs_mdrestore: EXTERNALLOG is a compat value, not incompat Message-ID: References: <170069440815.1865809.15572181471511196657.stgit@frogsfrogsfrogs> <170069445376.1865809.6391643475229742760.stgit@frogsfrogsfrogs> Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <170069445376.1865809.6391643475229742760.stgit@frogsfrogsfrogs> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Wed, Nov 22, 2023 at 03:07:33PM -0800, Darrick J. Wong wrote: > @@ -280,10 +278,8 @@ read_header_v2( > if (h->v2.xmh_reserved != 0) > fatal("Metadump header's reserved field has a non-zero value\n"); > > - want_external_log = !!(be32_to_cpu(h->v2.xmh_incompat_flags) & > - XFS_MD2_COMPAT_EXTERNALLOG); > - > - if (want_external_log && !mdrestore.external_log) > + if ((h->v2.xmh_compat_flags & cpu_to_be32(XFS_MD2_COMPAT_EXTERNALLOG)) && > + !mdrestore.external_log) Nit: overly long line. Trivially fixable by just inverting the conditions :) Otherwise looks good: Reviewed-by: Christoph Hellwig