From: Dave Chinner <david@fromorbit.com>
To: Kunhai Dai <daikunhai@didiglobal.com>
Cc: chandan.babu@oracle.com, djwong@kernel.org,
linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfs: adjust the offset of the log statistics line
Date: Tue, 5 Dec 2023 12:12:45 +1100 [thread overview]
Message-ID: <ZW55DaL4mF9vO91L@dread.disaster.area> (raw)
In-Reply-To: <20231204072644.1012309-1-daikunhai@didiglobal.com>
On Mon, Dec 04, 2023 at 02:26:44AM -0500, Kunhai Dai wrote:
> It would be more preferable to present xs_try_logspace and
> xs_sleep_logspace on the log line.
xs_try_logspace and xs_sleep_logspace are AIL tail pushing
statistics. They are related to reservation space exhaustion, not
journal operations, so they really are located in the correct stats
namespace.
Regardless of whether they are correctly located, we can't change
the layout of this file like this - it forms part of the user kABI.
The file format was defined back in June 2000 (early stages of the
XFS port to Linux) and so any change to the layout of the file will
break every application and script every written that parses it.
So while it might be "preferable" to change the order of stats in
the file to group them better, we simply cannot do that because it
will break userspace.
Cheers,
-Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2023-12-05 1:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 7:26 [PATCH] xfs: adjust the offset of the log statistics line Kunhai Dai
2023-12-05 1:12 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZW55DaL4mF9vO91L@dread.disaster.area \
--to=david@fromorbit.com \
--cc=chandan.babu@oracle.com \
--cc=daikunhai@didiglobal.com \
--cc=djwong@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox