From: Christoph Hellwig <hch@infradead.org>
To: Long Li <leo.lilong@huawei.com>
Cc: djwong@kernel.org, chandanbabu@kernel.org,
linux-xfs@vger.kernel.org, yi.zhang@huawei.com,
houtao1@huawei.com, yangerkun@huawei.com
Subject: Re: [PATCH 2/2] xfs: fix perag leak when growfs fails
Date: Mon, 4 Dec 2023 20:38:08 -0800 [thread overview]
Message-ID: <ZW6pMHNK/tUxsbuM@infradead.org> (raw)
In-Reply-To: <20231204043911.1273667-2-leo.lilong@huawei.com>
> +void
> +xfs_destroy_perag(
> + xfs_mount_t *mp,
> + xfs_agnumber_t agstart,
> + xfs_agnumber_t agend)
Not sure xfs_destroy_perag is the right name, as it frees a range of
AGs, how about xfs_free_unuses_perag_range?
Also a comment explaining that this must never be used for AGs that
have been visible (that is included in mp->m_sb.sb_agcount) would
probably be useful.
next prev parent reply other threads:[~2023-12-05 4:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 4:39 [PATCH 1/2] xfs: add lock protection when remove perag from radix tree Long Li
2023-12-04 4:39 ` [PATCH 2/2] xfs: fix perag leak when growfs fails Long Li
2023-12-05 4:38 ` Christoph Hellwig [this message]
2023-12-06 12:48 ` Long Li
2023-12-05 4:35 ` [PATCH 1/2] xfs: add lock protection when remove perag from radix tree Christoph Hellwig
2023-12-05 21:28 ` Dave Chinner
2023-12-06 12:32 ` Long Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZW6pMHNK/tUxsbuM@infradead.org \
--to=hch@infradead.org \
--cc=chandanbabu@kernel.org \
--cc=djwong@kernel.org \
--cc=houtao1@huawei.com \
--cc=leo.lilong@huawei.com \
--cc=linux-xfs@vger.kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox