From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="DqpS05ny" Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E15BFC4 for ; Wed, 29 Nov 2023 20:33:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=L2J70v8SgjujB46QoicQpTzo9ktlEXnXUA3bWLj7UIM=; b=DqpS05ny50Pas5oQ3b8TEts1fX DmpC0f9Tyt2+/DPlN5rcWT3UXx6w6QM6x5V06t2vyJcfJJyVWmdxPda5yN960UWXLH4DL/G2g3I1O r1kQtUE0XCVtahj+idV/QeH9dYAzRKPaYdRqWsI9WzDz0CWoHeYnFia/WdhBHxKbKWYe8dZDGniwo HNm/ckF26WqmxrsrhRcvLWICJ5kOssyAP8BevskY01ajHSMMgRiYNkFoRaR2yxeAXkzBw7KMcr6Jf AbgfJ5Oi24SDc09Q2cI2RTsiurjQC4+/tIGMWfAScIhNYGnUl72k8T1aWjUj4VMQ3MMxaVIyf9Rl6 Eo+CIrkA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1r8Yjq-009uZL-2T; Thu, 30 Nov 2023 04:33:22 +0000 Date: Wed, 29 Nov 2023 20:33:22 -0800 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Christoph Hellwig , linux-xfs@vger.kernel.org Subject: Re: [PATCH 1/4] xfs: force all buffers to be written during btree bulk load Message-ID: References: <170086926569.2770816.7549813820649168963.stgit@frogsfrogsfrogs> <170086926593.2770816.5504104328549141972.stgit@frogsfrogsfrogs> <20231128015041.GO2766956@frogsfrogsfrogs> <20231128170734.GZ2766956@frogsfrogsfrogs> Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231128170734.GZ2766956@frogsfrogsfrogs> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Tue, Nov 28, 2023 at 09:07:34AM -0800, Darrick J. Wong wrote: > > so I guess we'll need to go with the approach in this patch for now, > > maybe with a better commit log, and I'll look into finishing this work > > some time in the future. > > I think an xarray version of this would be less clunky than > xfs_delwri_buf with three pointers. It would, but xarray indices are unsigned longs, so we couldn't simply use the block number for it. So unless we decided to give up on building XFS on 32-bit kernels (which would nice for other reasons) it would need something more complicated.