From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: hch@lst.de, chandanbabu@kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 4/9] xfs: dont cast to char * for XFS_DFORK_*PTR macros
Date: Wed, 13 Dec 2023 20:46:39 -0800 [thread overview]
Message-ID: <ZXqIr3tyUB1+NmSL@infradead.org> (raw)
In-Reply-To: <170250783531.1399182.12180413015033895645.stgit@frogsfrogsfrogs>
On Wed, Dec 13, 2023 at 02:54:18PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Code in the next patch will assign the return value of XFS_DFORK_*PTR
> macros to a struct pointer. gcc complains about casting char* strings
> to struct pointers, so let's fix the macro's cast to void* to shut up
> the warnings.
>
> While we're at it, fix one of the scrub tests that uses PTR to use BOFF
> instead for a simpler integer comparison, since other linters whine
> about char* and void* comparisons.
Well, comparing different point types should be reject even by the
compiler. But the BOFF check look much nicer anyway..
The patch looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2023-12-14 4:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 22:51 [PATCHSET v28.2 0/9] xfs: online repair of inodes and forks Darrick J. Wong
2023-12-13 22:53 ` [PATCH 1/9] xfs: disable online repair quota helpers when quota not enabled Darrick J. Wong
2023-12-13 22:53 ` [PATCH 2/9] xfs: try to attach dquots to files before repairing them Darrick J. Wong
2023-12-13 22:54 ` [PATCH 3/9] xfs: add missing nrext64 inode flag check to scrub Darrick J. Wong
2023-12-13 22:54 ` [PATCH 4/9] xfs: dont cast to char * for XFS_DFORK_*PTR macros Darrick J. Wong
2023-12-14 4:46 ` Christoph Hellwig [this message]
2023-12-13 22:54 ` [PATCH 5/9] xfs: set inode sick state flags when we zap either ondisk fork Darrick J. Wong
2023-12-13 22:54 ` [PATCH 6/9] xfs: repair inode records Darrick J. Wong
2023-12-14 4:50 ` Christoph Hellwig
2023-12-13 22:55 ` [PATCH 7/9] xfs: zap broken inode forks Darrick J. Wong
2023-12-13 22:55 ` [PATCH 8/9] xfs: abort directory parent scrub scans if we encounter a zapped directory Darrick J. Wong
2023-12-13 22:55 ` [PATCH 9/9] xfs: skip the rmapbt search on an empty attr fork unless we know it was zapped Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXqIr3tyUB1+NmSL@infradead.org \
--to=hch@infradead.org \
--cc=chandanbabu@kernel.org \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox