From: Christoph Hellwig <hch@infradead.org>
To: "wuyifeng (C)" <wuyifeng10@huawei.com>
Cc: Carlos Maiolino <cem@kernel.org>,
"Darrick J. Wong" <djwong@kernel.org>,
linux-xfs@vger.kernel.org, louhongxiang@huawei.com
Subject: Re: [PATCH] xfs_grow: Remove xflag and iflag to reduce redundant temporary variables.
Date: Wed, 13 Dec 2023 21:00:39 -0800 [thread overview]
Message-ID: <ZXqL94xSn/bG6vgj@infradead.org> (raw)
In-Reply-To: <b2d069d4-b96a-443c-ad7e-5761b8f10f88@huawei.com>
On Thu, Dec 14, 2023 at 10:41:34AM +0800, wuyifeng (C) wrote:
> Both xflag and iflag are log flags. We can use the bits of lflag to
> indicate all log flags, which is a small code reconstruction.
I don't really see much of an upside here. This now requires me to
go out of the function to figure out what the flags means, and it adds
overly long lines making reading the code harder.
next prev parent reply other threads:[~2023-12-14 5:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 2:41 [PATCH] xfs_grow: Remove xflag and iflag to reduce redundant temporary variables wuyifeng (C)
2023-12-14 5:00 ` Christoph Hellwig [this message]
2023-12-14 17:07 ` Darrick J. Wong
[not found] <0e5P5B3pK_KjP_PgdGLjztYkfjNvEPuXovv9Fz2xm1gNnC0r5NfQf7wOK3OQNZ0GN0yqrL2qgeQpFuZfFv61og==@protonmail.internalid>
2023-12-07 8:39 ` wuyifeng (C)
2023-12-08 8:28 ` wuyifeng (C)
2023-12-11 11:10 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXqL94xSn/bG6vgj@infradead.org \
--to=hch@infradead.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=louhongxiang@huawei.com \
--cc=wuyifeng10@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox