public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
	Matthew Wilcox <willy@infradead.org>,
	linux-block <linux-block@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	xfs <linux-xfs@vger.kernel.org>
Subject: Re: Weird blockdev crash in 6.15-rc1?
Date: Thu, 10 Apr 2025 00:40:15 -0700	[thread overview]
Message-ID: <Z_d13yReJn2vqxCL@infradead.org> (raw)
In-Reply-To: <20250409190907.GO6266@frogsfrogsfrogs>

On Wed, Apr 09, 2025 at 12:09:07PM -0700, Darrick J. Wong wrote:
> Subject: [PATCH] block: fix race between set_blocksize and IO paths
> 
> With the new large sector size support, it's now the case that
> set_blocksize needs to change i_blksize and the folio order with no
> folios in the pagecache because the geometry changes cause problems with
> the bufferhead code.

Urrg.  I wish we could just get out of the game of messing with
block device inode settings from file systems.  I guess doing it when
using buffer_heads is hard, but file systems without buffer heads
should have a way out of even propagating their block size to the
block device inode.  And file systems with buffer heads should probably
not support large folios like this :P


  reply	other threads:[~2025-04-10  7:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-08 17:51 Weird blockdev crash in 6.15-rc1? Darrick J. Wong
2025-04-09 17:30 ` Darrick J. Wong
2025-04-09 19:09   ` Darrick J. Wong
2025-04-10  7:40     ` Christoph Hellwig [this message]
2025-04-10 15:25       ` Darrick J. Wong
2025-04-11 20:39         ` Luis Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z_d13yReJn2vqxCL@infradead.org \
    --to=hch@infradead.org \
    --cc=djwong@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox