From: Christoph Hellwig <hch@infradead.org>
To: Sam James <sam@gentoo.org>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-xfs@vger.kernel.org, Felix Janda <felix.janda@posteo.de>
Subject: Re: [PATCH v3 2/4] io: Assert we have a sensible off_t
Date: Sun, 21 Jan 2024 22:33:18 -0800 [thread overview]
Message-ID: <Za4MLpu/HlP60Oea@infradead.org> (raw)
In-Reply-To: <877ck2x8uc.fsf@gentoo.org>
On Mon, Jan 22, 2024 at 04:58:07AM +0000, Sam James wrote:
> >> - we don't really need this patch all
> >> - but cleaning up xfs_assert_largefile to just use static_assert would
> >> probably be nice to have anyway
> >
> > Thanks, I agree, but I think static_assert is C11 (and then it gets a
> > nicer name in C23). If it's still fine for us, I can then use it.
> >
> > Does it change your thinking at all or should I send a v4 with it
> > included?
>
> ping. I don't mind doing a followup, but I'd love to get this in given
> there's a bunch of other projects still to handle with this sort of
> problem.
Well, we certainly should drop this patch from the series. Adding
a cleanup to switch the existing odd way of asserting the size to
static_assert would be nice, but I don't think is required.
next prev parent reply other threads:[~2024-01-22 6:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 1:36 [PATCH v3 1/4] Remove use of LFS64 interfaces Sam James
2023-12-15 1:36 ` [PATCH v3 2/4] io: Assert we have a sensible off_t Sam James
2023-12-19 5:19 ` Darrick J. Wong
2023-12-19 5:54 ` Christoph Hellwig
2023-12-26 20:49 ` Sam James
2024-01-22 4:58 ` Sam James
2024-01-22 6:33 ` Christoph Hellwig [this message]
2024-01-22 7:22 ` Sam James
2023-12-15 1:36 ` [PATCH v3 3/4] build: Request 64-bit time_t where possible Sam James
2023-12-19 5:27 ` Darrick J. Wong
2023-12-15 1:36 ` [PATCH v3 4/4] io: Adapt to >= 64-bit time_t Sam James
2023-12-19 5:27 ` Darrick J. Wong
2023-12-19 5:55 ` [PATCH v3 1/4] Remove use of LFS64 interfaces Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Za4MLpu/HlP60Oea@infradead.org \
--to=hch@infradead.org \
--cc=felix.janda@posteo.de \
--cc=linux-xfs@vger.kernel.org \
--cc=sam@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).