From: Christoph Hellwig <hch@infradead.org>
To: Sam James <sam@gentoo.org>
Cc: linux-xfs@vger.kernel.org, "Darrick J . Wong" <djwong@kernel.org>
Subject: Re: [PATCH v4 3/3] io: Adapt to >= 64-bit time_t
Date: Sun, 21 Jan 2024 23:26:42 -0800 [thread overview]
Message-ID: <Za4Yso9cEs+TzU8w@infradead.org> (raw)
In-Reply-To: <20240122072351.3036242-3-sam@gentoo.org>
On Mon, Jan 22, 2024 at 07:23:28AM +0000, Sam James wrote:
> We now require (at least) 64-bit time_t, so we need to adjust some printf
> specifiers accordingly.
>
> Unfortunately, we've stumbled upon a ridiculous C mmoment whereby there's
> no neat format specifier (not even one of the inttypes ones) for time_t, so
> we cast to intmax_t and use %jd.
Shouldn't this go before patch 2 when applied?
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2024-01-22 7:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 7:23 [PATCH v4 1/3] Remove use of LFS64 interfaces Sam James
2024-01-22 7:23 ` [PATCH v4 2/3] build: Request 64-bit time_t where possible Sam James
2024-01-22 7:25 ` Christoph Hellwig
2024-01-22 7:23 ` [PATCH v4 3/3] io: Adapt to >= 64-bit time_t Sam James
2024-01-22 7:26 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Za4Yso9cEs+TzU8w@infradead.org \
--to=hch@infradead.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sam@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox