From: Dave Chinner <david@fromorbit.com>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: Chandan Babu R <chandan.babu@oracle.com>,
linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
"Darrick J . Wong" <djwong@kernel.org>,
Mateusz Guzik <mjguzik@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
Waiman Long <longman@redhat.com>
Subject: Re: [PATCH v5 0/3] Remove the XFS mrlock
Date: Tue, 16 Jan 2024 14:07:26 +1100 [thread overview]
Message-ID: <ZaXy7uKOvtiTadCr@dread.disaster.area> (raw)
In-Reply-To: <20240111212424.3572189-1-willy@infradead.org>
On Thu, Jan 11, 2024 at 09:24:21PM +0000, Matthew Wilcox (Oracle) wrote:
> XFS has an mrlock wrapper around the rwsem which adds only the
> functionality of knowing whether the rwsem is currently held in read
> or write mode. Both regular rwsems and rt-rwsems know this, they just
> don't expose it as an API. By adding that, we can remove the XFS mrlock
> as well as improving the debug assertions for the mmap_lock when lockdep
> is disabled.
>
> I have an ack on the first patch from Peter, so I would like to see this
> merged through the XFS tree since most of what it touches is XFS.
With the minor nits that have already been noticed fix up, the whole
series looks good to me.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2024-01-16 3:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 21:24 [PATCH v5 0/3] Remove the XFS mrlock Matthew Wilcox (Oracle)
2024-01-11 21:24 ` [PATCH v5 1/3] locking: Add rwsem_assert_held() and rwsem_assert_held_write() Matthew Wilcox (Oracle)
2024-01-12 4:52 ` Waiman Long
2024-01-13 0:38 ` Darrick J. Wong
2024-01-11 21:24 ` [PATCH v5 2/3] xfs: Replace xfs_isilocked with xfs_assert_ilocked Matthew Wilcox (Oracle)
2024-01-13 0:37 ` Darrick J. Wong
2024-01-11 21:24 ` [PATCH v5 3/3] xfs: Remove mrlock wrapper Matthew Wilcox (Oracle)
2024-01-13 0:29 ` Darrick J. Wong
2024-01-16 3:07 ` Dave Chinner [this message]
2024-02-14 22:05 ` [PATCH v5 0/3] Remove the XFS mrlock Matthew Wilcox
2024-02-14 22:17 ` Darrick J. Wong
2024-02-15 14:23 ` Chandan Babu R
2024-02-19 15:06 ` Chandan Babu R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZaXy7uKOvtiTadCr@dread.disaster.area \
--to=david@fromorbit.com \
--cc=chandan.babu@oracle.com \
--cc=djwong@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=mjguzik@gmail.com \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox