From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org, chandan.babu@oracle.com
Subject: Re: [PATCH] xfs: read only mounts with fsopen mount API are busted
Date: Mon, 15 Jan 2024 21:21:29 -0800 [thread overview]
Message-ID: <ZaYSWRrFuhtJYbof@infradead.org> (raw)
In-Reply-To: <20240116043307.893574-1-david@fromorbit.com>
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> +/*
> + * WARNING: do not initialise any parameters in this function that depend on
> + * mount option parsing having already been performed as this can be called from
> + * fsopen() before any parameters have been set.
> + */
> static int xfs_init_fs_context(
... while you're at it, can you switch this to the normal XFS format:
static int
xfs_init_fs_context(
next prev parent reply other threads:[~2024-01-16 5:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 4:33 [PATCH] xfs: read only mounts with fsopen mount API are busted Dave Chinner
2024-01-16 5:21 ` Christoph Hellwig [this message]
2024-01-17 2:33 ` Ian Kent
-- strict thread matches above, loose matches on Subject: below --
2023-08-23 22:02 Dave Chinner
2023-08-23 22:18 ` Darrick J. Wong
2023-08-23 22:46 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZaYSWRrFuhtJYbof@infradead.org \
--to=hch@infradead.org \
--cc=chandan.babu@oracle.com \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox