From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: cem@kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/2] xfs_db: use directio for device access
Date: Wed, 17 Jan 2024 10:30:23 -0800 [thread overview]
Message-ID: <Zagcv3rWRQMeTujZ@infradead.org> (raw)
In-Reply-To: <169567915609.2320255.8945830759168479067.stgit@frogsfrogsfrogs>
On Mon, Sep 25, 2023 at 02:59:16PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> XFS and tools (mkfs, copy, repair) don't generally rely on the block
> device page cache, preferring instead to use directio. For whatever
> reason, the debugger was never made to do this, but let's do that now.
>
> This should eliminate the weird fstests failures resulting from
> udev/blkid pinning a cache page while the unmounting filesystem writes
> to the superblock such that xfs_db finds the stale pagecache instead of
> the post-unmount superblock.
After some debugging I found out that this breaks a bunch of tests
(at least xfs/002 xfs/070 xfs/424 in the quick group) on 4k device
because xfs_db tries some unaligned reads.
For xfs/002 that is the libxfs_buf_read in __set_cur, when setting the
type to data, but I haven't looked at the other test in detail.
Should I look into finding all these assumptions in xfs_db, or
just make the direct I/O enablement conditional n a 612 byte sector
size?
next prev parent reply other threads:[~2024-01-17 18:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <KT7JxvGZnq9-QNN8kBpbKekDJ2BKLQOGCjpSETPSGhPryNhXo_L71VZTCaXaI2AY3cjBINdJO97ZbUCOOYZSeg==@protonmail.internalid>
2023-09-25 21:59 ` [PATCHSET 0/2] xfs_db: use directio for filesystem access Darrick J. Wong
2023-09-25 21:59 ` [PATCH 1/2] libxfs: make platform_set_blocksize optional with directio Darrick J. Wong
2023-09-25 21:59 ` [PATCH 2/2] xfs_db: use directio for device access Darrick J. Wong
2024-01-17 18:30 ` Christoph Hellwig [this message]
2024-01-18 1:32 ` Darrick J. Wong
2024-01-18 4:21 ` Christoph Hellwig
2024-01-19 0:52 ` Darrick J. Wong
2023-10-03 11:47 ` [PATCHSET 0/2] xfs_db: use directio for filesystem access Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zagcv3rWRQMeTujZ@infradead.org \
--to=hch@infradead.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox