From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Carlos Maiolino <cmaiolino@redhat.com>,
"Darrick J . Wong" <djwong@kernel.org>,
linux-xfs@vger.kernel.org
Subject: Re: fix log sector size detection v2
Date: Thu, 18 Jan 2024 08:14:30 +1100 [thread overview]
Message-ID: <ZahDNkhNhd5s7ZR8@dread.disaster.area> (raw)
In-Reply-To: <20240117173312.868103-1-hch@lst.de>
On Wed, Jan 17, 2024 at 06:33:07PM +0100, Christoph Hellwig wrote:
> Hi all,
>
> this series cleans up the libxfs toplogy code and then fixes detection
> of the log sector size in mkfs.xfs, so that it doesn't create smaller
> than possible log sectors by default on > 512 byte sector size devices.
>
> Note that this doesn't cleanup the types of the topology members, as
> that creeps all the way into platform_findsize. Which has a lot more
> cruft that should be dealth with and is worth it's own series.
>
> Changes since v1:
> - fix a spelling mistake
> - add a few more cleanups
Series looks good to me. Nice cleanup!
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2024-01-17 21:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 17:33 fix log sector size detection v2 Christoph Hellwig
2024-01-17 17:33 ` [PATCH 1/5] libxfs: remove the unused fs_topology_t typedef Christoph Hellwig
2024-01-17 17:33 ` [PATCH 2/5] libxfs: refactor the fs_topology structure Christoph Hellwig
2024-01-17 23:55 ` Darrick J. Wong
2024-01-17 17:33 ` [PATCH 3/5] libxfs: remove the S_ISREG check from blkid_get_topology Christoph Hellwig
2024-01-17 23:57 ` Darrick J. Wong
2024-01-17 17:33 ` [PATCH 4/5] libxfs: also query log device topology in get_topology Christoph Hellwig
2024-01-17 17:33 ` [PATCH 5/5] mkfs: use a sensible log sector size default Christoph Hellwig
2024-01-29 9:25 ` Pankaj Raghav (Samsung)
2024-01-17 21:14 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZahDNkhNhd5s7ZR8@dread.disaster.area \
--to=david@fromorbit.com \
--cc=cmaiolino@redhat.com \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox