From: Christoph Hellwig <hch@infradead.org>
To: Andrey Albershteyn <aalbersh@redhat.com>
Cc: linux-xfs@vger.kernel.org, djwong@kernel.org, chandan.babu@oracle.com
Subject: Re: [RESEND] xfs: reset XFS_ATTR_INCOMPLETE filter on node removal
Date: Wed, 24 Jan 2024 01:42:51 -0800 [thread overview]
Message-ID: <ZbDbm6ZvNL3oBzPf@infradead.org> (raw)
In-Reply-To: <20240124094032.1150014-1-aalbersh@redhat.com>
On Wed, Jan 24, 2024 at 10:40:33AM +0100, Andrey Albershteyn wrote:
> In XFS_DAS_NODE_REMOVE_ATTR case, xfs_attr_mode_remove_attr() sets
> filter to XFS_ATTR_INCOMPLETE. The filter is then reset in
> xfs_attr_complete_op() if XFS_DA_OP_REPLACE operation is performed.
>
> The filter is not reset though if XFS just removes the attribute
> (args->value == NULL) with xfs_attr_defer_remove(). attr code goes
> to XFS_DAS_DONE state.
>
> Fix this by always resetting XFS_ATTR_INCOMPLETE filter. The replace
> operation already resets this filter in anyway and others are
> completed at this step hence don't need it.
>
> Signed-off-by: Andrey Albershteyn <aalbersh@redhat.com>
Shuld this have a Fixes: tag?
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2024-01-24 9:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 9:40 [RESEND] xfs: reset XFS_ATTR_INCOMPLETE filter on node removal Andrey Albershteyn
2024-01-24 9:42 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbDbm6ZvNL3oBzPf@infradead.org \
--to=hch@infradead.org \
--cc=aalbersh@redhat.com \
--cc=chandan.babu@oracle.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox