From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 423CE1DDC9 for ; Fri, 26 Jan 2024 16:47:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706287680; cv=none; b=oe6DHfzfG6R9fuu2vRNBaRZQPALo6lFJN4fxlrQEckyfWHktJauXfA6ji2Sccv1d1GzmBK+DdohKmkzvqdiyLVArRXLSXk6gP4Hd9Olfs1sSh0WyBtHdRAgITbst3FLdbbZdK1OF0bE3BYxYnVODlwSJ0cIriK++Qd8uC3+mkmw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706287680; c=relaxed/simple; bh=9AwpEy6qYRfmO3+tq6XP9FLPPejA7zIm46FOl1ym7vc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hG14EqAtzF2JpmU4xHJb91aCNSHBuZeOKJGSTUt9KwRrvSTLHFzRJNsb4+mod57FXiDVN3p8Vo3vzg7BIoMFGs9cliHtYB53DCjKeaQ/ZyEQ7U5/QePLUzy6LDz3CGbQp8pHw/7c19i47Zzq2yFytzBOaeD8lQKZAWlYRPY9x2E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=AradtZLz; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="AradtZLz" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=9jCfrEz+uX7VbktVuh7g8Wwg/zmEUFcGpXjFQj1/e30=; b=AradtZLzE5EFRBBMIuipukN5Ks V0aQ8rlsOcOgtvrXCNKlzIkTT6WfOqrNDJDZBn6ZJCOBDkHjAF6b4MizDoE311TRqVCj18XwFpuMz nL9I5O3bcfFqXVD1KfKmkl1YIy+jsm7GwqhUk4AliJ98Gv5/hddGShiVEF0GOUzqP/Ly1yoQjg3NC SDNXwO85hxcW6rxqdMGJJLKKVVDlFhRyaeNR75V56zJ1rwzbVVZ2lNZIEJEy/xrotsp8dumOlWgQf ooi2O0WWQNDeVJUxqBBCueV6HpYToNxfbdGJR4f+2ey7gAy7eDkU3fngLlbjchsE1w/AQH4tlQqcx rzcpR0qw==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTPMw-0000000EDl8-328J; Fri, 26 Jan 2024 16:47:54 +0000 Date: Fri, 26 Jan 2024 16:47:54 +0000 From: Matthew Wilcox To: Christoph Hellwig Cc: Chandan Babu R , "Darrick J. Wong" , Hugh Dickins , Andrew Morton , linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: put the xfs xfile abstraction on a diet v2 Message-ID: References: <20240126132903.2700077-1-hch@lst.de> Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240126132903.2700077-1-hch@lst.de> On Fri, Jan 26, 2024 at 02:28:42PM +0100, Christoph Hellwig wrote: > this series refactors and simplifies the code in the xfs xfile > abstraction, which is a thing layer on a kernel-use shmem file. OK, I've finished reviewing the series. I'm not offering R-b for the xfiles portions as I feel I don't understand the code well enough to do a high quality review. In general it looks good, and I only had minor quibbles; the overall direction is good.