From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Dave Chinner <david@fromorbit.com>,
xfs <linux-xfs@vger.kernel.org>
Subject: Re: xfs_clear_incompat_log_features considered harmful?
Date: Thu, 8 Feb 2024 22:33:07 -0800 [thread overview]
Message-ID: <ZcXHI5baZZlZsfvi@infradead.org> (raw)
In-Reply-To: <20240206052329.GR616564@frogsfrogsfrogs>
On Mon, Feb 05, 2024 at 09:23:29PM -0800, Darrick J. Wong wrote:
> >
> > Well, even with the current code base in Darrick's queue a mount alone
> > won't upgrade features, you need to do an explicit exchrange or online
> > repair operation. And I think we should basically never do log or
> > other format incompatible changes without an explicit user action.
>
> Should I add a flags bit to the ioctls so that programs can force them
> on if the process has CAP_SYS_ADMIN?
Please not, that's just a horrible interface.
> Or would you rather a mount option
> "-o allow_log_upgrades=1" so that's totally under control of whoever
> writes fstab?
>
> The first option probably turns into an "and now everyone sets this"
> thing; the second one clutters up the mount options.
Yes, that or a CAP_SYS_ADMIN ioctl on the fs.
next prev parent reply other threads:[~2024-02-09 6:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 23:00 xfs_clear_incompat_log_features considered harmful? Darrick J. Wong
2024-02-01 4:33 ` Christoph Hellwig
2024-02-05 1:09 ` Dave Chinner
2024-02-05 6:45 ` Christoph Hellwig
2024-02-06 5:23 ` Darrick J. Wong
2024-02-09 6:33 ` Christoph Hellwig [this message]
2024-02-06 5:30 ` Darrick J. Wong
2024-02-07 0:14 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcXHI5baZZlZsfvi@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox