From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B112634F3 for ; Tue, 13 Feb 2024 21:19:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707859168; cv=none; b=tKP/U8CtGt2Y7Gi1zBDBPUBQnwBSdIZwWHei/Q90ioZHkVsFZCRnpUfx1UjMdF0bZXG5xTDPMePZDjae/XqTmbe0rP8UFdKvTz2Dso10yMprGd9/TwsW0mCT5pYgG/ptWzMWOKJZAA7DDrsaJ6ei53Dnw+PxABiT8O1TVgbKLpU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707859168; c=relaxed/simple; bh=u+37GdGC/RFOsezdEzqNgPOn7MJSkWmd3LKNGiI80J0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=F1p1H7c6F36+STHdJ2/7JZ3aWcGT+NjUQyUqBXT4l1+ikDBxTJSqKdmGgEwugNiqe0/izXOvPv1ppOD1+eIAJZMa559l/sD1PfnC94rdSqTSQzIQM0/hDnkY92lblq3xC1JcWWFz+JTzeJYKKI2lV0LAYc1AfQd0UC4IBRqSyIo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fromorbit.com; spf=pass smtp.mailfrom=fromorbit.com; dkim=pass (2048-bit key) header.d=fromorbit-com.20230601.gappssmtp.com header.i=@fromorbit-com.20230601.gappssmtp.com header.b=muUHpyeB; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fromorbit.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fromorbit.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fromorbit-com.20230601.gappssmtp.com header.i=@fromorbit-com.20230601.gappssmtp.com header.b="muUHpyeB" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1db562438e0so819565ad.3 for ; Tue, 13 Feb 2024 13:19:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1707859166; x=1708463966; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gewUBLZJkZ832bNkMemwPNuP6AjEYnwmsKdeIxmXvlI=; b=muUHpyeBf1KIuKy4jG193Pg6QL2rXVjfMpLAi11TuNtxp/i+odCs4Bk+pTRQ4rTg8g ZpklTrmKbPMZglwk9ylLhWFypJSWszxfohmsFJBqFtWo5ybO+tjVQ3d5hSyJgl14C55O wvvTf3EZJG2OS/gQjFfGZZU7fZoHkLHwvFdsQKS4cok0IBeWFYWU7X4Or2i8uS3NTd+r Y8Q1RCy3aP4IjYhWyI/JeBxF16hBbJpVqCbevQrOHnGJBnZXMKOSS5HITHSI+6KinZ/M pvfNhHTnkTZ50s2WaQs/os0ab3TpObwgSZ8mkbkLg4XXagTE1W4NnfwPkVVcEYNIii6Q gsOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707859166; x=1708463966; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gewUBLZJkZ832bNkMemwPNuP6AjEYnwmsKdeIxmXvlI=; b=QIvOzOkUBtL4Xo5Cv3TZcqF4JJIYMyrKyvBzSO0O6hgqd60qc9S9NIB7rL+LLMYuGk nv9iq0DCdDcClWm2mh4zdorQrQy4qBK7PgsMvFxSN0iThJu47twVAiyc5AxnvlDcY9Q1 OmHbYew3hVKoS40u0zcb7s0pgDFLcOKcz6EDBveNTtD/WtwfWsw+PBaWbBJ6/MzfQYQs pA5meSNiRDMzylBrtxQu4p+K7HLHvb5gjzrW0nmm9vo6D9hhdVekNDhqdwvRs1YZb8ya gBa/k5zhmdQCDlP6D6r0rCrGNjbz1iyE8XDTSpPFQ/+aRIdwPjwYdvxApGBkTCdXNmnb OvFQ== X-Gm-Message-State: AOJu0YwEK3LxOmkUcb9JQQryo4OoNBMPBjBNJqL+tMEjl25aJ5nPHQHw rvpyozs4zcn1NudGm6HYQgJ1kV0VFvTJYsuhSUKDShcogs7BhmYrca2VPOpP+qE= X-Google-Smtp-Source: AGHT+IGLUSZXB3ylBDOhdlT0T3KZyXplzyMRS717PUcEqeBADrUjMdBE30QvnJ3A0SsgCKfJuXzdRA== X-Received: by 2002:a17:902:7c90:b0:1d8:e4b8:95e5 with SMTP id y16-20020a1709027c9000b001d8e4b895e5mr735185pll.32.1707859166637; Tue, 13 Feb 2024 13:19:26 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWO0TbDjhh/ndSsZJYVcwjhjhY0VK36KvnOtetues9rvO72mKN9S6yrohbe5HpmsHReSYH//kgA3cLVZxJSMxKOBS/2qAwhj/Ve3rjcJb72MNFOXoUbYL/1CHTiHPkUj3x8m/33hM3Sh4vq1BII/6HK8bXM3Mc+Yi72mVEPrASerHOqghSCpuXChXE6/J76YAtOSgKQzIE87VSXT8enpMMaMSj+ozTtytuBa4adQH6IY58agY4JRs+hnLXJzLmsg0ygeU0Hb0UpvuBuGvaPYhTsC2dXedD1qO8CynIO3MzKF6GndNboo1QM78YmrQ8do/9qEnP5vdEp/v481jEju4juRSj8dnYazah1MlNqE9Axz1VtwYEiLPIwFr1EaSFkyDujAUTN2jw/42pr6bDcyywOqMSEwl6dTczNiRo= Received: from dread.disaster.area (pa49-181-38-249.pa.nsw.optusnet.com.au. [49.181.38.249]) by smtp.gmail.com with ESMTPSA id e21-20020a170902d39500b001d8e5a3be8asm2466833pld.259.2024.02.13.13.19.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 13:19:26 -0800 (PST) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1ra0BX-0066dX-0Y; Wed, 14 Feb 2024 08:19:23 +1100 Date: Wed, 14 Feb 2024 08:19:23 +1100 From: Dave Chinner To: "Pankaj Raghav (Samsung)" Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, mcgrof@kernel.org, gost.dev@samsung.com, akpm@linux-foundation.org, kbusch@kernel.org, djwong@kernel.org, chandan.babu@oracle.com, p.raghav@samsung.com, linux-kernel@vger.kernel.org, hare@suse.de, willy@infradead.org, linux-mm@kvack.org Subject: Re: [RFC v2 13/14] xfs: add an experimental CONFIG_XFS_LBS option Message-ID: References: <20240213093713.1753368-1-kernel@pankajraghav.com> <20240213093713.1753368-14-kernel@pankajraghav.com> Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240213093713.1753368-14-kernel@pankajraghav.com> On Tue, Feb 13, 2024 at 10:37:12AM +0100, Pankaj Raghav (Samsung) wrote: > From: Pankaj Raghav > > Add an experimental CONFIG_XFS_LBS option to enable LBS support in XFS. > Retain the ASSERT for PAGE_SHIFT if CONFIG_XFS_LBS is not enabled. > > Signed-off-by: Pankaj Raghav NAK. There it no reason for this existing - the same code is run regardless of the state of this config variable just with a difference in min folio order. All it does is increase the test matrix arbitrarily - now we have two kernel configs we have to test and there's no good reason for doing that. -Dave. -- Dave Chinner david@fromorbit.com