From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 552628480 for ; Tue, 13 Feb 2024 22:45:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707864308; cv=none; b=tG3iFL8H5E4GQhTqApTrTuBm1bu6AdSZA/hMGZ3uuvIP3LJG5DvxlZCI4lGchgmguraQ0enWdyhEppW4a3bCXeHnmzztARogYECdGZHlXUUCuPUVtITbg8dbdnlBA0whsCseV7erlkD+5TcBtiMlMZeUz+E3BRQ/hr+w9QLW6G4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707864308; c=relaxed/simple; bh=HBYciFeZBNHgQsYnR6EeVMEsINZyKu5uLE+AmLv/jjc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=txUrbVfjjLM/F3MWKOEjdWXT9BRD+/yN955e2+5oObXqkP/IikDFPJjy1TjqXottcSx16EG3YsEaXVMSL90C2+mF/wOBL+xSevyZ5aHZ+WoHvzRRs42TwOfDSV55/kCJCXfemoCN7M9RbLz69SFBVX2O9O2tGzN3RHDZ+dNt/ts= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fromorbit.com; spf=pass smtp.mailfrom=fromorbit.com; dkim=pass (2048-bit key) header.d=fromorbit-com.20230601.gappssmtp.com header.i=@fromorbit-com.20230601.gappssmtp.com header.b=bJZB4ozt; arc=none smtp.client-ip=209.85.215.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fromorbit.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fromorbit.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fromorbit-com.20230601.gappssmtp.com header.i=@fromorbit-com.20230601.gappssmtp.com header.b="bJZB4ozt" Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-5bdbe2de25fso3796865a12.3 for ; Tue, 13 Feb 2024 14:45:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1707864307; x=1708469107; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VSX+f82UonQUib7g2mNUoZMszrXmjLE1tVvT69rZd4k=; b=bJZB4oztXzNtD0mM4yzJN3tF3CC56qYCy35KlYe/cocJWq58cE/fjW+tImjoZrNl8O IJEUQSg+zmgovotdGcG/Awk7mY/gjCvmW98h4szuVuLLOpCNMMIupmbFyDc9dDqMqbmI SGlIFKDJTevEuvXlX3Xe2F/S2FYsKN4ZkP9ORmgdEwmjkcZHFuwOyv5OiGBkeI2jyFjD GeIbzt8NiYbHc+krnkK5JQ6AcZUR1uSp8zAVAb5mKn/qfD0pC1I6hp5mjqNczFYLg8+d gAxg9GoRn+Q5wLm5J1hSZ+FuX+afKO9tlLY4z7C7/lG5NsDV0XFvGtFSYRg3E0yqhIDI e56Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707864307; x=1708469107; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VSX+f82UonQUib7g2mNUoZMszrXmjLE1tVvT69rZd4k=; b=WJE2TKbEf2FhjOO0y3b7GLki++NFBAYm7DVkL9FtdWqzvBSHCtl2M9QB5xiSH9/NgF U3DlDr3dlaOEO4sWkCusgH5Mx/X+LmGx9bpmOkPGsUiXlxY4C7E30dfsn0VqO/tl2hqy FdJnivo7aD2qzDtdevzXVxXXDXSjsgPLAOO4/1IEd00InQ2YLTVudIgz1xh2oYpc7uZ8 oFzDQ3H7Vw8dPeYMUsKxpfNIbTWcEaN0MQPBlLcQsjtXfTucRxAU1axp9Xbd1yyCEIpH 151SjTY2RQ564p0RCwIfp3KTIltrYNHYsH1nHq6AlJFGNoWgARkYpQTGWLHqqJNemIWR llNA== X-Gm-Message-State: AOJu0YzieYSPVIwiMnrfkFIl1xZ+qJ8ARXV3SjRX14WeonTZc+1DUBrP 9vSUTJjkLMKRylYmiV5R5gBAG62osWpt5W7xuaTrlvb4eom6BqDUdzP4Zu0h/0o= X-Google-Smtp-Source: AGHT+IFH5HuMfmvbE4pmOe8SUsWhXGmBy/f8wCL8BkqKfjRUwp7p68YSbmTclZDRaoQsSL6V13FV8Q== X-Received: by 2002:a05:6a20:43a0:b0:1a0:60b2:45b with SMTP id i32-20020a056a2043a000b001a060b2045bmr1445690pzl.6.1707864306761; Tue, 13 Feb 2024 14:45:06 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUuBRLYz/ZMeJAh5p4WoSM7f4br1opheRIOVUqkjHYvdjjF+sUGuH9OCmB++AXrk+SYj0c14b2v3mPw++EN5XDbXUgzFjupG5q/2qyZlwfpXk7ulACrPgHmp4r3KNjuLVlqX12ACdOM6raWkbIOSUq2HvhIHlPQKjzHqg2RSsAnT6WjoVb9ntIfUxaXQ78lEaHrGDv1By1Kx5UK/Y9eYvQtynsSTLzuvYmO/JroPwUvPGCYTRZsNKaVHDXL2Wgr68Ql9oDQEQBRIXLlsJAB5f9dVuP6JW0oOzHEGa1FnkQfY1sJUTbp7aeZP+0CR3s3kN7F/lWm0sk7hJOK661u6uz4PF40Z9d0XYHNhlZk242dwNhEkKooSKpml+jjj+Xroa6a3KvQe2FjcC3GQztgrVCGprCGpX0MeQ8Z2Ck= Received: from dread.disaster.area (pa49-181-38-249.pa.nsw.optusnet.com.au. [49.181.38.249]) by smtp.gmail.com with ESMTPSA id r18-20020a62e412000000b006e0503f467bsm7953728pfh.39.2024.02.13.14.45.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 14:45:06 -0800 (PST) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1ra1WQ-0068Mq-2a; Wed, 14 Feb 2024 09:45:02 +1100 Date: Wed, 14 Feb 2024 09:45:02 +1100 From: Dave Chinner To: "Pankaj Raghav (Samsung)" Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, mcgrof@kernel.org, gost.dev@samsung.com, akpm@linux-foundation.org, kbusch@kernel.org, djwong@kernel.org, chandan.babu@oracle.com, p.raghav@samsung.com, linux-kernel@vger.kernel.org, hare@suse.de, willy@infradead.org, linux-mm@kvack.org Subject: Re: [RFC v2 13/14] xfs: add an experimental CONFIG_XFS_LBS option Message-ID: References: <20240213093713.1753368-1-kernel@pankajraghav.com> <20240213093713.1753368-14-kernel@pankajraghav.com> Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Feb 13, 2024 at 10:54:07PM +0100, Pankaj Raghav (Samsung) wrote: > On Wed, Feb 14, 2024 at 08:19:23AM +1100, Dave Chinner wrote: > > On Tue, Feb 13, 2024 at 10:37:12AM +0100, Pankaj Raghav (Samsung) wrote: > > > From: Pankaj Raghav > > > > > > Add an experimental CONFIG_XFS_LBS option to enable LBS support in XFS. > > > Retain the ASSERT for PAGE_SHIFT if CONFIG_XFS_LBS is not enabled. > > > > > > Signed-off-by: Pankaj Raghav > > > > NAK. > > > > There it no reason for this existing - the same code is run > > regardless of the state of this config variable just with a > > difference in min folio order. All it does is increase the test > > matrix arbitrarily - now we have two kernel configs we have to test > > and there's no good reason for doing that. > > I did not have this CONFIG in the first round but I thought it might > help retain the existing behaviour until we deem the feature stable. > > But I get your point. So we remove this CONFIG and just have an > experimental warning during mount when people are using the LBS support? Yes. -Dave. -- Dave Chinner david@fromorbit.com