From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-xfs@vger.kernel.org, hch@lst.de
Subject: Re: [PATCH 5/6] xfs: hoist multi-fsb allocation unit detection to a helper
Date: Tue, 27 Feb 2024 07:51:27 -0800 [thread overview]
Message-ID: <Zd4E_0nWedVHXl6s@infradead.org> (raw)
In-Reply-To: <170900011214.938068.18217925414531189912.stgit@frogsfrogsfrogs>
> +static inline bool xfs_inode_has_bigallocunit(struct xfs_inode *ip)
> +{
> + return XFS_IS_REALTIME_INODE(ip) && ip->i_mount->m_sb.sb_rextsize > 1;
> +}
Given that bigallocunit is an entirely new term in XFS, maybe add
a big fat comment explaining it?
Otherwise this looks useful.
next prev parent reply other threads:[~2024-02-27 15:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 2:17 [PATCHSET v29.4 02/13] xfs: refactorings for atomic file content exchanges Darrick J. Wong
2024-02-27 2:19 ` [PATCH 1/6] xfs: move inode lease breaking functions to xfs_inode.c Darrick J. Wong
2024-02-27 15:49 ` Christoph Hellwig
2024-02-27 2:19 ` [PATCH 2/6] xfs: move xfs_iops.c declarations out of xfs_inode.h Darrick J. Wong
2024-02-27 15:49 ` Christoph Hellwig
2024-02-27 2:20 ` [PATCH 3/6] xfs: declare xfs_file.c symbols in xfs_file.h Darrick J. Wong
2024-02-27 15:50 ` Christoph Hellwig
2024-02-27 2:20 ` [PATCH 4/6] xfs: create a new helper to return a file's allocation unit Darrick J. Wong
2024-02-27 15:50 ` Christoph Hellwig
2024-02-28 18:41 ` Darrick J. Wong
2024-02-27 2:20 ` [PATCH 5/6] xfs: hoist multi-fsb allocation unit detection to a helper Darrick J. Wong
2024-02-27 15:51 ` Christoph Hellwig [this message]
2024-02-27 16:10 ` Darrick J. Wong
2024-02-27 16:57 ` Christoph Hellwig
2024-02-27 2:20 ` [PATCH 6/6] xfs: refactor non-power-of-two alignment checks Darrick J. Wong
2024-02-27 15:51 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zd4E_0nWedVHXl6s@infradead.org \
--to=hch@infradead.org \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox