From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-xfs@vger.kernel.org, hch@lst.de
Subject: Re: [PATCH 1/6] xfs: create a blob array data structure
Date: Wed, 28 Feb 2024 08:00:50 -0800 [thread overview]
Message-ID: <Zd9YsjLkMZ5fccF0@infradead.org> (raw)
In-Reply-To: <170900013644.939212.14951407608685671445.stgit@frogsfrogsfrogs>
> +/* Discard pages backing a range of the xfile. */
> +void
> +xfile_discard(
> + struct xfile *xf,
> + loff_t pos,
> + u64 count)
> +{
> + trace_xfile_discard(xf, pos, count);
> +
> + shmem_truncate_range(file_inode(xf->file), pos, pos + count - 1);
> +}
Can you split this xfile infrastructure addition into a separate patch
instead of hiding it here?
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2024-02-28 16:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 2:18 [PATCHSET v29.4 07/13] xfs: online repair of extended attributes Darrick J. Wong
2024-02-27 2:28 ` [PATCH 1/6] xfs: create a blob array data structure Darrick J. Wong
2024-02-28 16:00 ` Christoph Hellwig [this message]
2024-02-28 17:48 ` Darrick J. Wong
2024-02-27 2:29 ` [PATCH 2/6] xfs: use atomic extent swapping to fix user file fork data Darrick J. Wong
2024-02-28 16:01 ` Christoph Hellwig
2024-02-27 2:29 ` [PATCH 3/6] xfs: repair extended attributes Darrick J. Wong
2024-02-28 17:05 ` Christoph Hellwig
2024-02-27 2:29 ` [PATCH 4/6] xfs: scrub should set preen if attr leaf has holes Darrick J. Wong
2024-02-28 17:06 ` Christoph Hellwig
2024-02-27 2:29 ` [PATCH 5/6] xfs: flag empty xattr leaf blocks for optimization Darrick J. Wong
2024-02-28 17:06 ` Christoph Hellwig
2024-02-27 2:30 ` [PATCH 6/6] xfs: create an xattr iteration function for scrub Darrick J. Wong
2024-02-28 17:11 ` Christoph Hellwig
2024-02-28 18:07 ` Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2023-12-31 19:30 [PATCHSET v29.0 20/28] xfs: online repair of extended attributes Darrick J. Wong
2023-12-31 20:35 ` [PATCH 1/6] xfs: create a blob array data structure Darrick J. Wong
2024-01-05 5:53 ` Christoph Hellwig
2024-01-06 1:33 ` Darrick J. Wong
2024-01-06 6:42 ` Christoph Hellwig
2024-01-06 18:55 ` Darrick J. Wong
2024-01-08 17:12 ` Darrick J. Wong
2020-01-01 1:03 [PATCH v22 0/6] xfs: online repair of inode data Darrick J. Wong
2020-01-01 1:03 ` [PATCH 1/6] xfs: create a blob array data structure Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zd9YsjLkMZ5fccF0@infradead.org \
--to=hch@infradead.org \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).