From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Chandan Babu R <chandan.babu@oracle.com>,
"Darrick J. Wong" <djwong@kernel.org>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 6/9] xfs: support RT inodes in xfs_mod_delalloc
Date: Tue, 20 Feb 2024 10:30:03 +1100 [thread overview]
Message-ID: <ZdPke6g0cp1jcMn4@dread.disaster.area> (raw)
In-Reply-To: <20240219063450.3032254-7-hch@lst.de>
On Mon, Feb 19, 2024 at 07:34:47AM +0100, Christoph Hellwig wrote:
> To prepare for re-enabling delalloc on RT devices, track the data blocks
> (which use the RT device when the inode sits on it) and the indirect
> blocks (which don't) separately to xfs_mod_delalloc, and add a new
> percpu counter to also track the RT delalloc blocks.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
.....
> @@ -4938,7 +4938,7 @@ xfs_bmap_del_extent_delay(
> fdblocks += del->br_blockcount;
>
> xfs_add_fdblocks(mp, fdblocks);
> - xfs_mod_delalloc(mp, -(int64_t)fdblocks);
> + xfs_mod_delalloc(ip, -(long)del->br_blockcount, -da_diff);
> return error;
That change of cast type looks wrong.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2024-02-19 23:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 6:34 bring back RT delalloc support Christoph Hellwig
2024-02-19 6:34 ` [PATCH 1/9] xfs: make XFS_TRANS_LOWMODE match the other XFS_TRANS_ definitions Christoph Hellwig
2024-02-19 6:34 ` [PATCH 2/9] xfs: move RT inode locking out of __xfs_bunmapi Christoph Hellwig
2024-02-19 23:55 ` Dave Chinner
2024-02-20 5:10 ` Christoph Hellwig
2024-02-19 6:34 ` [PATCH 3/9] xfs: split xfs_mod_freecounter Christoph Hellwig
2024-02-19 23:21 ` Dave Chinner
2024-02-20 7:28 ` Christoph Hellwig
2024-02-20 16:08 ` Christoph Hellwig
2024-02-21 0:00 ` Dave Chinner
2024-02-19 6:34 ` [PATCH 4/9] xfs: reinstate RT support in xfs_bmapi_reserve_delalloc Christoph Hellwig
2024-02-19 6:34 ` [PATCH 5/9] xfs: cleanup fdblock/frextent accounting in xfs_bmap_del_extent_delay Christoph Hellwig
2024-02-19 6:34 ` [PATCH 6/9] xfs: support RT inodes in xfs_mod_delalloc Christoph Hellwig
2024-02-19 23:30 ` Dave Chinner [this message]
2024-02-20 5:14 ` Christoph Hellwig
2024-02-19 6:34 ` [PATCH 7/9] xfs: look at m_frextents in xfs_iomap_prealloc_size for RT allocations Christoph Hellwig
2024-02-19 6:34 ` [PATCH 8/9] xfs: stop the steal (of data blocks for RT indirect blocks) Christoph Hellwig
2024-02-19 23:47 ` Dave Chinner
2024-02-20 5:13 ` Christoph Hellwig
2024-02-19 6:34 ` [PATCH 9/9] xfs: reinstate delalloc for RT inodes (if sb_rextsize == 1) Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdPke6g0cp1jcMn4@dread.disaster.area \
--to=david@fromorbit.com \
--cc=chandan.babu@oracle.com \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox