From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Dave Chinner <david@fromorbit.com>,
Chandan Babu R <chandanrlinux@gmail.com>,
xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH v2] xfs: fix log recovery erroring out on refcount recovery failure
Date: Thu, 22 Feb 2024 23:05:50 -0800 [thread overview]
Message-ID: <ZdhDzq3dmhsUwq3w@infradead.org> (raw)
In-Reply-To: <20240223054817.GN6188@frogsfrogsfrogs>
On Thu, Feb 22, 2024 at 09:48:17PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Per the comment in the error case of xfs_reflink_recover_cow, zero out
> any error (after shutting down the log) so that we actually kill any new
> intent items that might have gotten logged by later recovery steps.
> Discovered by xfs/434, which few people actually seem to run.
Talking about xfs/434, it just caused me some nasty debugging headache
last week. It is the first of only three tests requiring a loadable
xfs module, and when there is an xfs.ko for the uname around but xfs
is built into the kernel as it is for my usual test configs it fails
in completely weird and hard to debug ways.
The fact that it requires a modular xfs might also be the reason why
it's rarely run.
The fix itself looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2024-02-23 7:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 5:48 [PATCH v2] xfs: fix log recovery erroring out on refcount recovery failure Darrick J. Wong
2024-02-23 7:05 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdhDzq3dmhsUwq3w@infradead.org \
--to=hch@infradead.org \
--cc=chandanrlinux@gmail.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox