Re: [PATCH v5 19/24] xfs: don't allow to enable DAX on fs-verity sealsed inode

Darrick J. Wong
2024-03-07T22:09:57Z

On Mon, Mar 04, 2024 at 08:10:42PM +0100, Andrey Albershteyn wrote:
> fs-verity doesn't support DAX. Forbid filesystem to enable DAX on
> inodes which already have fs-verity enabled. The opposite is checked
> when fs-verity is enabled, it won't be enabled if DAX is.

What's the problem with allowing fsdax and fsverity at the same time?
Was that merely not in scope, or is there a fundamental incompatibility
between the two?

--D

> Signed-off-by: Andrey Albershteyn <aalbersh@redhat.com>
> ---
> fs/xfs/xfs_iops.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c
> index 0e5cdb82b231..6f97d777f702 100644
> --- a/fs/xfs/xfs_iops.c
> +++ b/fs/xfs/xfs_iops.c
> @@ -1213,6 +1213,8 @@ xfs_inode_should_enable_dax(
> return false;
> if (!xfs_inode_supports_dax(ip))
> return false;
> + if (ip->i_diflags2 & XFS_DIFLAG2_VERITY)
> + return false;
> if (xfs_has_dax_always(ip->i_mount))
> return true;
> if (ip->i_diflags2 & XFS_DIFLAG2_DAX)
> --
> 2.42.0
>
>