Re: [PATCH v5 24/24] xfs: enable ro-compat fs-verity flag

Darrick J. Wong
2024-03-07T22:16:14Z

On Mon, Mar 04, 2024 at 08:10:47PM +0100, Andrey Albershteyn wrote:
> Finalize fs-verity integration in XFS by making kernel fs-verity
> aware with ro-compat flag.
>
> Signed-off-by: Andrey Albershteyn <aalbersh@redhat.com>
> ---
> fs/xfs/libxfs/xfs_format.h | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/fs/xfs/libxfs/xfs_format.h b/fs/xfs/libxfs/xfs_format.h
> index 3ce2902101bc..be66f0ab20cb 100644
> --- a/fs/xfs/libxfs/xfs_format.h
> +++ b/fs/xfs/libxfs/xfs_format.h
> @@ -355,10 +355,11 @@ xfs_sb_has_compat_feature(
> #define XFS_SB_FEAT_RO_COMPAT_INOBTCNT (1 << 3) /* inobt block counts */
> #define XFS_SB_FEAT_RO_COMPAT_VERITY (1 << 4) /* fs-verity */
> #define XFS_SB_FEAT_RO_COMPAT_ALL \
> - (XFS_SB_FEAT_RO_COMPAT_FINOBT | \
> - XFS_SB_FEAT_RO_COMPAT_RMAPBT | \
> - XFS_SB_FEAT_RO_COMPAT_REFLINK| \
> - XFS_SB_FEAT_RO_COMPAT_INOBTCNT)
> + (XFS_SB_FEAT_RO_COMPAT_FINOBT | \
> + XFS_SB_FEAT_RO_COMPAT_RMAPBT | \
> + XFS_SB_FEAT_RO_COMPAT_REFLINK | \
> + XFS_SB_FEAT_RO_COMPAT_INOBTCNT| \

You might as well add a few more spaces here ^^ for future expansion
if you're going to reflow the whole macro definition.

(or just leave it alone which is what I would've done)

Up to you; the rest is
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> + XFS_SB_FEAT_RO_COMPAT_VERITY)
> #define XFS_SB_FEAT_RO_COMPAT_UNKNOWN ~XFS_SB_FEAT_RO_COMPAT_ALL
> static inline bool
> xfs_sb_has_ro_compat_feature(
> --
> 2.42.0
>
>