From: Christoph Hellwig <hch@infradead.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] Remove duplicate definitions in xfsprogs
Date: Sun, 17 Mar 2024 14:09:43 -0700 [thread overview]
Message-ID: <ZfdcF0FJJL948Z_E@infradead.org> (raw)
In-Reply-To: <ZfNymFxNLL9gtybv@casper.infradead.org>
On Thu, Mar 14, 2024 at 09:56:40PM +0000, Matthew Wilcox wrote:
> This is userspace. I have no idea what I'm doing.
Heh.
> diff --git a/db/init.c b/db/init.c
> index b108a06cfe..42757e44c6 100644
> --- a/db/init.c
> +++ b/db/init.c
> @@ -39,7 +39,6 @@ int force;
> struct xfs_mount xmount;
> struct xfs_mount *mp;
> struct xlog xlog;
> -libxfs_init_t x;
I did rework the libxfs_init structure (and remove this typedef)
in xfsprogs for-next, which I think should have also fixed the
duplicated declaration for "x".
The other fixups look ok to me. The global variables in libraries
aren't exactly a nice pattern, but I think we'll have to live with
them for now.
prev parent reply other threads:[~2024-03-17 21:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 21:56 [PATCH] Remove duplicate definitions in xfsprogs Matthew Wilcox
2024-03-17 21:09 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfdcF0FJJL948Z_E@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox