From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
zlang@redhat.com, fstests@vger.kernel.org,
linux-xfs@vger.kernel.org, guan@eryu.me
Subject: Re: [PATCH 3/4] generic/{166,167,333,334,671}: actually fill the filesystem with snapshots
Date: Fri, 29 Mar 2024 22:39:48 -0700 [thread overview]
Message-ID: <ZgelpI4W_e6NyyTA@infradead.org> (raw)
In-Reply-To: <20240329230720.GE6379@frogsfrogsfrogs>
On Fri, Mar 29, 2024 at 04:07:20PM -0700, Darrick J. Wong wrote:
> Hmm. Well my initial thought was that the snapshot could fall back to
> buffered copies of file1 so that we wouldn't abort the test well before
> actually filling up the filesystem.
Btw, can we please stop sing snaphot in the test description for
reflink copies? That's a really confusing term to use in this context..
> But you're right that my solution smells off -- we want to test reflink
> dealing with ENOSPC. Perhaps the right thing to do is to truncate and
> rewrite file1 after a _cp_reflink fails, so that the next time through
> the loop we'll be reflinking extents from a (probably less full) AG.
That does sound better.
next prev parent reply other threads:[~2024-03-30 5:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 2:43 [PATCHSET] fstests: random fixes for v2024.02.09 Darrick J. Wong
2024-03-27 2:43 ` [PATCH 1/4] xfs/270: fix rocompat regex Darrick J. Wong
2024-03-27 2:48 ` [PATCH v1.1 " Darrick J. Wong
2024-03-27 11:32 ` Christoph Hellwig
2024-03-27 2:43 ` [PATCH 2/4] xfs/176: fix stupid failure Darrick J. Wong
2024-03-27 11:32 ` Christoph Hellwig
2024-03-27 2:43 ` [PATCH 3/4] generic/{166,167,333,334,671}: actually fill the filesystem with snapshots Darrick J. Wong
2024-03-27 16:59 ` Christoph Hellwig
2024-03-29 23:07 ` Darrick J. Wong
2024-03-30 5:39 ` Christoph Hellwig [this message]
2024-03-30 7:14 ` Zorro Lang
2024-03-27 2:43 ` [PATCH 4/4] generic: test MADV_POPULATE_READ with IO errors Darrick J. Wong
2024-03-30 7:12 ` Zorro Lang
2024-03-30 15:31 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgelpI4W_e6NyyTA@infradead.org \
--to=hch@infradead.org \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox